From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058CEC433F5 for ; Fri, 17 Sep 2021 02:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D79B4611C0 for ; Fri, 17 Sep 2021 02:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243122AbhIQChF (ORCPT ); Thu, 16 Sep 2021 22:37:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:33766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243072AbhIQCgM (ORCPT ); Thu, 16 Sep 2021 22:36:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 99430611C0; Fri, 17 Sep 2021 02:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631846091; bh=eVlCf9tNIsvO/ehpnl4cvb77fCAZUquM30wCN7BHxDg=; h=From:To:Cc:Subject:Date:From; b=CzyKUvjgz6S77nWg+sin2sOr2FLl/08D9cdp5cdIM4Rgf/jyZYNvyFr41Rxof4PbW FtGJt3FkvuNxmFW2mKA57t8wSxdd0e6EbdOiKrjJxfaRmlA7NOFO7qvFYlkPkVs27S GhDYyayZVcG0gTWAdA3O5+k0KNUNt+zB+jE8IQbx6eBH6OfL46RxMpgAfdQQH9njsi agN92zNhk3fVZ3xp6KVoWica21wlniBNhemgrI2RCJoaxg2fqGVVmbjESdB0kCXy8m nPxuh/IIT1Qm0Vw67RjT+G1qphTF3BiP9OHqyQpyQj/WtzhDX3QysjUvoxChV8GfxF vG6V4ZRfEl2VQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Thierry Reding , Sasha Levin , lee.jones@linaro.org, linux-pwm@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 1/5] pwm: img: Don't modify HW state in .remove() callback Date: Thu, 16 Sep 2021 22:34:45 -0400 Message-Id: <20210917023449.816713-1-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Uwe Kleine-König [ Upstream commit c68eb29c8e9067c08175dd0414f6984f236f719d ] A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/pwm/pwm-img.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c index 22c002e685b3..37f9b688661d 100644 --- a/drivers/pwm/pwm-img.c +++ b/drivers/pwm/pwm-img.c @@ -329,23 +329,7 @@ static int img_pwm_probe(struct platform_device *pdev) static int img_pwm_remove(struct platform_device *pdev) { struct img_pwm_chip *pwm_chip = platform_get_drvdata(pdev); - u32 val; - unsigned int i; - int ret; - - ret = pm_runtime_get_sync(&pdev->dev); - if (ret < 0) { - pm_runtime_put(&pdev->dev); - return ret; - } - - for (i = 0; i < pwm_chip->chip.npwm; i++) { - val = img_pwm_readl(pwm_chip, PWM_CTRL_CFG); - val &= ~BIT(i); - img_pwm_writel(pwm_chip, PWM_CTRL_CFG, val); - } - pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) img_pwm_runtime_suspend(&pdev->dev); -- 2.30.2