From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02240C433F5 for ; Fri, 17 Sep 2021 02:35:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1239611C0 for ; Fri, 17 Sep 2021 02:35:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243293AbhIQChI (ORCPT ); Thu, 16 Sep 2021 22:37:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:33824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242780AbhIQCgO (ORCPT ); Thu, 16 Sep 2021 22:36:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C803561246; Fri, 17 Sep 2021 02:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631846092; bh=r5gC87Mi61bZXKut/kHn+g9b/1QBUhPKRwnKlZTsP+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SrXt0FBUvA4B9yZS531lUzmr+oqd4Z86ZZFs2kZI6HXGcWPBKnc6WOV1rdBKLpsp9 afxwN52TH1BO28CC8NFsTCddyKWV8ZfA3SmNL0rSKqfMpOQBGX7ZlokYsS1G88czVU SInUirEm8xuXdsccouvww8VFT+xxy9FqmpbCDMDk2uwv+A6KSN/VpFBvjbVPwqc39N 42tHS3Vqmy/mTOtvWu632rAG+iT+akcZGj2gIoCj4xvhEK967aSAF2nQNU1zaEV5lv pnMghEE743WSbyyoQpuUKNGcGtH+kq6TYQaUxUycTvBNtTpdRlRagJRxtnpjodvlP3 1guvL6OOxXO2Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Thierry Reding , Sasha Levin , lee.jones@linaro.org, heiko@sntech.de, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 2/5] pwm: rockchip: Don't modify HW state in .remove() callback Date: Thu, 16 Sep 2021 22:34:46 -0400 Message-Id: <20210917023449.816713-2-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210917023449.816713-1-sashal@kernel.org> References: <20210917023449.816713-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Uwe Kleine-König [ Upstream commit 9d768cd7fd42bb0be16f36aec48548fca5260759 ] A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/pwm/pwm-rockchip.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 6ad6aad215cf..8c0af705c5ae 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -383,20 +383,6 @@ static int rockchip_pwm_remove(struct platform_device *pdev) { struct rockchip_pwm_chip *pc = platform_get_drvdata(pdev); - /* - * Disable the PWM clk before unpreparing it if the PWM device is still - * running. This should only happen when the last PWM user left it - * enabled, or when nobody requested a PWM that was previously enabled - * by the bootloader. - * - * FIXME: Maybe the core should disable all PWM devices in - * pwmchip_remove(). In this case we'd only have to call - * clk_unprepare() after pwmchip_remove(). - * - */ - if (pwm_is_enabled(pc->chip.pwms)) - clk_disable(pc->clk); - clk_unprepare(pc->pclk); clk_unprepare(pc->clk); -- 2.30.2