From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C5F1C433FE for ; Fri, 17 Sep 2021 08:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41B3C61251 for ; Fri, 17 Sep 2021 08:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245372AbhIQIJo (ORCPT ); Fri, 17 Sep 2021 04:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245116AbhIQIIz (ORCPT ); Fri, 17 Sep 2021 04:08:55 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B13D5C0613C1 for ; Fri, 17 Sep 2021 01:06:34 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id c8-20020a7bc008000000b002e6e462e95fso9290849wmb.2 for ; Fri, 17 Sep 2021 01:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hB7whJFC0X8jOEkpS+/j+QNCR9hvpVa/Awmx8A0MRmU=; b=OPrvSKkFZvhwm193cSIbqQHx/eo2pw87C/6h038Kz70XHnA65ySfjnFsPM8lLGvqwR dIDm/fwcYtNzjJArfbwvk7ZoBO3s2vUN1Ygcjus0tMnjInGiYUQlF+P4uvui3MLXxxnl 0WN0Pc2zT+9/8ofknBFPogV/fAVUkgNVHlCJh6LRrnk98912M+IxzZQ8wXXRgA8TyT3S WA1xVJbFuxxBe7SJ08ttsbWsWIZAYJmH/GQdfOq8UBpdjEx2GSyQsrIXTIoci1qx385W CyMGQQ53OF/9K/T5WNmHnq9N6rPDpgewl7jPtVCpx5VzhOH8Qm0BCj21TaoG800WHSoo +BAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hB7whJFC0X8jOEkpS+/j+QNCR9hvpVa/Awmx8A0MRmU=; b=bmmyYj7YwZKnPtinDDjVOwqFz9xXSjmhCCe2JmEEL2XWBJxk7/H63ai232A8y9wLIT cZNHI+DvC+r1PL62dfsipx99gJAlynApKq2iHWXWlNbi+iQMw24GDN+1rBZmVJ8v6L8W OiolX8VIZqFSQkEQP5pSSSgamhCyX+zpAfigB1HS4900bDdNU/bQ/Ewv3d8tEEDRtrpy EfIoFyWcPFvVbanIQ/F7K6OzlNFPXSlyfeLAdo9W235Eq8OCtKUeYJSrSd5JLNjd6KpX i3dIEOSYF6atb0lTUJsUJE4ZW/aSMIwVJaixWs5uwgDls7fU7AQkJAmg9v3rJeE7SFlH 4YTQ== X-Gm-Message-State: AOAM531A2dJav3DzQ+T9U+m+MdrMrFeOb6p6IaIyfnEtNf0Cb9iYU2t+ iwhWiEC3Rv69LPXFxcM1U+Q= X-Google-Smtp-Source: ABdhPJwaa6pAbo6VGnY6WtTnQy1Cm+8Lky1p3WA3OxSVLh6+rJVDyoFLMn3tEAsGk+pOyjUKlUCIeg== X-Received: by 2002:a7b:c1d3:: with SMTP id a19mr8988699wmj.114.1631865993358; Fri, 17 Sep 2021 01:06:33 -0700 (PDT) Received: from localhost.localdomain ([2a02:8108:96c0:3b88::ae40]) by smtp.gmail.com with ESMTPSA id r129sm5690890wmr.7.2021.09.17.01.06.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 01:06:33 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/4] staging: r8188eu: remove if test that is always true Date: Fri, 17 Sep 2021 10:06:13 +0200 Message-Id: <20210917080615.25819-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210917080615.25819-1-straube.linux@gmail.com> References: <20210917080615.25819-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The test "if (pHalData->rf_type == RF_1T1R)" is always true in this driver. Remove the test and the dead else arm. Signed-off-by: Michael Straube --- drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c index ad0782259654..03b68b3e3550 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c @@ -533,14 +533,7 @@ int PHY_RF6052_Config8188E(struct adapter *Adapter) struct hal_data_8188e *pHalData = GET_HAL_DATA(Adapter); int rtStatus = _SUCCESS; - /* */ - /* Initialize general global value */ - /* */ - /* TODO: Extend RF_PATH_C and RF_PATH_D in the future */ - if (pHalData->rf_type == RF_1T1R) - pHalData->NumTotalRFPath = 1; - else - pHalData->NumTotalRFPath = 2; + pHalData->NumTotalRFPath = 1; /* */ /* Config BB and RF */ -- 2.33.0