Re: [PATCH v2] mtd: rawnand: xway: No hardcoded ECC engine, use device tree setting

Jan Hoffmann
2021-09-27T20:32:23Z

Hi Miquèl,

> So what I propose is:
> - in the driver probe: set the default to software ECC
> - in the attach() hook: drop the line setting the engine_type to SOFT.
>
> Please check the below diff and tell me if it works for you. I'll then
> propose a wider series fixing the other drivers as well.

I can confirm that your patch fixes the issue.

I tested using kernel 5.10 on a Fritzbox 7362 SL (with on-die ECC
configured via device tree which was broken before). I also checked on
a Fritzbox 7412 (this device uses software ECC). Both are working with
this patch.

Thanks,
Jan