public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	martin@kaiser.cx, fmdefrancesco@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Michael Straube <straube.linux@gmail.com>
Subject: [PATCH v2 06/12] staging: r8188eu: remove more dead code from ODM_Write_DIG()
Date: Sat, 18 Sep 2021 11:24:37 +0200	[thread overview]
Message-ID: <20210918092443.8724-7-straube.linux@gmail.com> (raw)
In-Reply-To: <20210918092443.8724-1-straube.linux@gmail.com>

SupportICType is ODM_RTL8188E in this driver. Remove code that is
never executed.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/hal/odm.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index cac4f8ff7b63..48c10b78f4a5 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -466,12 +466,8 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI)
 
 	if (pDM_DigTable->CurIGValue != CurrentIGI) {
 		ODM_SetBBReg(pDM_Odm, ODM_REG(IGI_A, pDM_Odm), ODM_BIT(IGI, pDM_Odm), CurrentIGI);
-		if (pDM_Odm->SupportICType != ODM_RTL8188E)
-			ODM_SetBBReg(pDM_Odm, ODM_REG(IGI_B, pDM_Odm), ODM_BIT(IGI, pDM_Odm), CurrentIGI);
-
 		pDM_DigTable->CurIGValue = CurrentIGI;
 	}
-/*  Add by Neil Chen to enable edcca to MP Platform */
 }
 
 /* Need LPS mode for CE platform --2012--08--24--- */
-- 
2.33.0


  parent reply	other threads:[~2021-09-18  9:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18  9:24 [PATCH v2 00/12] staging: r8188eu: remove odm_RegDefine11AC.h Michael Straube
2021-09-18  9:24 ` [PATCH v2 01/12] staging: r8188eu: remove comments from odm_interface.h Michael Straube
2021-09-18  9:24 ` [PATCH v2 02/12] staging: r8188eu: remove unused macros " Michael Straube
2021-09-18  9:24 ` [PATCH v2 03/12] staging: r8188eu: remove _ic_type from macro _cat in odm_interface.h Michael Straube
2021-09-18  9:24 ` [PATCH v2 04/12] staging: r8188eu: remove dead code from ODM_Write_DIG() Michael Straube
2021-09-18  9:24 ` [PATCH v2 05/12] staging: r8188eu: remove unnecessary if statement Michael Straube
2021-09-18  9:24 ` Michael Straube [this message]
2021-09-18  9:24 ` [PATCH v2 07/12] staging: r8188eu: remove macro ODM_REG Michael Straube
2021-09-18  9:24 ` [PATCH v2 08/12] staging: r8188eu: remove macro ODM_BIT Michael Straube
2021-09-18  9:24 ` [PATCH v2 09/12] staging: r8188eu: remove unnecessary if statements Michael Straube
2021-09-18  9:24 ` [PATCH v2 10/12] staging: r8188eu: remove dead code from odm.c Michael Straube
2021-09-18  9:24 ` [PATCH v2 11/12] staging: r8188eu: remove macros ODM_IC_11{N,AC}_SERIES Michael Straube
2021-09-18  9:24 ` [PATCH v2 12/12] staging: r8188eu: remove header file odm_RegDefine11AC.h Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210918092443.8724-7-straube.linux@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=fmdefrancesco@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox