From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Straube <straube.linux@gmail.com>
Cc: Larry.Finger@lwfinger.net, Phillip Potter <phil@philpotter.co.uk>,
Greg KH <gregkh@linuxfoundation.org>,
"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed?
Date: Mon, 20 Sep 2021 11:33:30 +0300 [thread overview]
Message-ID: <20210920083330.GO2088@kadam> (raw)
In-Reply-To: <7f1c135a-d85d-d271-f315-d665a5fe1472@gmail.com>
On Sat, Sep 18, 2021 at 03:31:48PM +0200, Michael Straube wrote:
> Hi Larry, Phillip and all.
>
> While removing code that checks for the chip type I stumbled upon this:
>
>
> void odm_DynamicTxPowerNIC(struct odm_dm_struct *pDM_Odm)
> {
> if (!(pDM_Odm->SupportAbility & ODM_BB_DYNAMIC_TXPWR))
> return;
>
> if (pDM_Odm->SupportICType == ODM_RTL8188E) {
> /* ??? */
> /* This part need to be redefined. */
> }
> }
Always just delete dead code. The future is very hard to predict so
don't leave things lying around because of possible futures. Don't be
a hoarder.
regards,
dan carpenter
prev parent reply other threads:[~2021-09-20 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 13:31 staging: r8188eu: Can odm_DynamicTxPowerNIC() be removed? Michael Straube
2021-09-18 16:46 ` Larry Finger
2021-09-18 17:32 ` Michael Straube
2021-09-20 8:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920083330.GO2088@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox