Re: [PATCH v5 2/8] configfs: use BIT() for internal flags

Bartosz Golaszewski
2021-09-20T14:46:55Z

On Mon, Sep 20, 2021 at 4:30 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Mon, Sep 20, 2021 at 04:29:30PM +0200, Geert Uytterhoeven wrote:
> > Hi Christoph,
> >
> > On Mon, Sep 20, 2021 at 4:09 PM Christoph Hellwig <hch@lst.de> wrote:
> > > On Mon, Sep 20, 2021 at 04:05:03PM +0200, Bartosz Golaszewski wrote:
> > > > For better readability and maintenance: use the BIT() macro for flag
> > > > definitions.
> > >
> > > NAK. BIT() is the stupidest macro in the kernel and shall not be used
> > > ever. And I'm pretty sure we had this discussion a few times.
> >
> > Care to explain why it is a stupid macro?
>
> Please look at the previous thread. I'm tired of this discussion.

Hi Geert!

The only previous answer from Christoph is this:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2399968.html

Bart