Re: [PATCH v5 2/8] configfs: use BIT() for internal flags

Christoph Hellwig
2021-09-20T14:15:40Z

On Mon, Sep 20, 2021 at 04:13:37PM +0200, Bartosz Golaszewski wrote:
> On Mon, Sep 20, 2021 at 4:09 PM Christoph Hellwig <hch@lst.de> wrote:
> >
> > On Mon, Sep 20, 2021 at 04:05:03PM +0200, Bartosz Golaszewski wrote:
> > > For better readability and maintenance: use the BIT() macro for flag
> > > definitions.
> >
> > NAK. BIT() is the stupidest macro in the kernel and shall not be used
> > ever. And I'm pretty sure we had this discussion a few times.
>
> Yep and the general consensus among the kernel developers still is to
> use the BIT() macro. Even for this patch there were three separate
> comments from high-profile developers to use BIT().
>
> Also: this really is bikeshedding at this point, given that the core
> subject of this series is elsewhere.

Given that we had this dicussion before I'll gladly tell you that your
any seris with a BIT() conversion will go stright to /dev/null after
the first warning from now on. You had more than one warning.