Re: [PATCH v5 2/8] configfs: use BIT() for internal flags

Geert Uytterhoeven
2021-09-20T14:50:16Z

Hi Bartosz,

On Mon, Sep 20, 2021 at 4:47 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> On Mon, Sep 20, 2021 at 4:30 PM Christoph Hellwig <hch@lst.de> wrote:
> > On Mon, Sep 20, 2021 at 04:29:30PM +0200, Geert Uytterhoeven wrote:
> > > On Mon, Sep 20, 2021 at 4:09 PM Christoph Hellwig <hch@lst.de> wrote:
> > > > On Mon, Sep 20, 2021 at 04:05:03PM +0200, Bartosz Golaszewski wrote:
> > > > > For better readability and maintenance: use the BIT() macro for flag
> > > > > definitions.
> > > >
> > > > NAK. BIT() is the stupidest macro in the kernel and shall not be used
> > > > ever. And I'm pretty sure we had this discussion a few times.
> > >
> > > Care to explain why it is a stupid macro?
> >
> > Please look at the previous thread. I'm tired of this discussion.
>
> The only previous answer from Christoph is this:
> https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2399968.html

Yep, found that one, too.

Now, as these definitions do not correspond to hardware register bits,
perhaps use an enum?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds