* [PATCH] common/module: use patient module removal
@ 2021-09-21 17:49 Luis Chamberlain
0 siblings, 0 replies; only message in thread
From: Luis Chamberlain @ 2021-09-21 17:49 UTC (permalink / raw)
To: fstests
Cc: hare, dgilbert, jeyu, lucas.demarchi, linux-kernel,
Luis Chamberlain, Eryu Guan
Now that scsi_debug has been using the patient module removal
for a while, let's generalize its use for the other use cases.
This likey will fix some odd false positives due to races.
Suggested-by: Eryu Guan <guan@eryu.me>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
common/module | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/module b/common/module
index 0392f20c..ead0f881 100644
--- a/common/module
+++ b/common/module
@@ -16,7 +16,7 @@ _reload_module()
{
local module="$1"
- modprobe -r "${module}" || _fail "${module} unload failed"
+ _patient_rmmod "${module}" || _fail "${module} unload failed"
modprobe "${module}" || _fail "${module} load failed"
}
@@ -44,7 +44,7 @@ _require_loadable_module()
local module="$1"
modinfo "${module}" > /dev/null 2>&1 || _notrun "${module}: must be a module."
- modprobe -r "${module}" || _notrun "Require ${module} to be unloadable"
+ _patient_rmmod "${module}" || _notrun "Require ${module} to be unloadable"
modprobe "${module}" || _notrun "${module} load failed"
}
@@ -64,7 +64,7 @@ _require_loadable_fs_module()
test -n "${had_scratchfs}" && _scratch_unmount
local unload_ok=""
local load_ok=""
- modprobe -r "${module}" || unload_ok=0
+ _patient_rmmod "${module}" || unload_ok=0
modprobe "${module}" || load_ok=0
test -n "${had_scratchfs}" && _scratch_mount 2> /dev/null
test -n "${had_testfs}" && _test_mount 2> /dev/null
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-21 17:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-21 17:49 [PATCH] common/module: use patient module removal Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox