Re: [PATCH v3 2/4] sched: Introduce migratable()

Phil Auld
2021-08-17T19:30:29Z

On Tue, Aug 17, 2021 at 07:09:25PM +0200 Sebastian Andrzej Siewior wrote:
> On 2021-08-11 21:13:52 [+0100], Valentin Schneider wrote:
> > diff --git a/include/linux/sched.h b/include/linux/sched.h
> > index debc960f41e3..8ba7b4a7ee69 100644
> > --- a/include/linux/sched.h
> > +++ b/include/linux/sched.h
> > @@ -1715,6 +1715,16 @@ static inline bool is_percpu_thread(void)
> > #endif
> > }
> >
> > +/* Is the current task guaranteed to stay on its current CPU? */
> > +static inline bool migratable(void)
>
> I'm going to rename this in my tree to `is_migratable' because of

It's better anyway. See is_percpu_thread() 5 lines above :)

> |security/keys/trusted-keys/trusted_core.c:45:22: error: ‘migratable’ redeclared as different kind of symbol
> | 45 | static unsigned char migratable;
> | | ^~~~~~~~~~
> |In file included from arch/arm64/include/asm/compat.h:16,
> | from arch/arm64/include/asm/stat.h:13,
> | from include/linux/stat.h:6,
> | from include/linux/sysfs.h:22,
> | from include/linux/kobject.h:20,
> | from include/linux/of.h:17,
> | from include/linux/irqdomain.h:35,
> | from include/linux/acpi.h:13,
> | from include/linux/tpm.h:21,
> | from include/keys/trusted-type.h:12,
> | from security/keys/trusted-keys/trusted_core.c:10:
> |include/linux/sched.h:1719:20: note: previous definition of ‘migratable’ was here
> | 1719 | static inline bool migratable(void)
> | | ^~~~~~~~~~
>
> Sebastian
>

--