From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB18C4332F for ; Thu, 23 Sep 2021 03:43:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65DFD60F4C for ; Thu, 23 Sep 2021 03:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239348AbhIWDo3 (ORCPT ); Wed, 22 Sep 2021 23:44:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:41756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239711AbhIWDmQ (ORCPT ); Wed, 22 Sep 2021 23:42:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 58CF961284; Thu, 23 Sep 2021 03:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632368420; bh=kfeGRGZkAXMR0B0xTJTek11JoPNEHeSIlmsRD75iRUM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=StwcmxRisUq6Dd8idiQytU/leu3Yymeer2OqiMITSF3ZQY3wjhr5gvXVYDZ8tMmuQ aux1QgRKJK5Lvd0KEL+mp0PTv2S6NwSe5Lhoii7FKaewYQSal14jCvIjNy25/zEFT6 zqsjBON034WtnCnEe35f52jF1+8YgH1mqDLhSAO0bLMrkilxJ0aTEMXdIhivoSPOeu /RVkcgvscaU9dYoAJP4YfIpHwRfpCPXJPNimjOsFa9+wjE/Hqhz4OvotfosFjHGhPU EVLslKbi+aiumSYWwjHq0cSInXswzu/CD7OD51rsTu8OqHg9Y9WPPW+Y2dau9qKKiT MLtwHKmF70YVw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Li , Mark Rutland , Catalin Marinas , Sasha Levin , will@kernel.org, maz@kernel.org, pcc@google.com, peterz@infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.14 10/13] arm64: Mark __stack_chk_guard as __ro_after_init Date: Wed, 22 Sep 2021 23:39:56 -0400 Message-Id: <20210923033959.1421662-10-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210923033959.1421662-1-sashal@kernel.org> References: <20210923033959.1421662-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Li [ Upstream commit 9fcb2e93f41c07a400885325e7dbdfceba6efaec ] __stack_chk_guard is setup once while init stage and never changed after that. Although the modification of this variable at runtime will usually cause the kernel to crash (so does the attacker), it should be marked as __ro_after_init, and it should not affect performance if it is placed in the ro_after_init section. Signed-off-by: Dan Li Acked-by: Mark Rutland Link: https://lore.kernel.org/r/1631612642-102881-1-git-send-email-ashimida@linux.alibaba.com Signed-off-by: Catalin Marinas Signed-off-by: Sasha Levin --- arch/arm64/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 2ff327651ebe..dac14125f8a2 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -61,7 +61,7 @@ #ifdef CONFIG_CC_STACKPROTECTOR #include -unsigned long __stack_chk_guard __read_mostly; +unsigned long __stack_chk_guard __ro_after_init; EXPORT_SYMBOL(__stack_chk_guard); #endif -- 2.30.2