Re: [PATCH 2/6] ptrace: Remove the unnecessary arguments from arch_ptrace_stop

Kees Cook
2021-09-24T15:26:15Z

On Thu, Sep 23, 2021 at 07:10:03PM -0500, Eric W. Biederman wrote:
>
> Both arch_ptrace_stop_needed and arch_ptrace_stop are called with an
> exit_code and a siginfo structure. Neither argument is used by any of
> the implementations so just remove the unneeded arguments.
>
> The two arechitectures that implement arch_ptrace_stop are ia64 and
> sparc. Both architectures flush their register stacks before a
> ptrace_stack so that all of the register information can be accessed
> by debuggers.
>
> As the question of if a register stack needs to be flushed is
> independent of why ptrace is stopping not needing arguments make sense.
>
> Cc: David Miller <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Yeah, this is a no-op change. No one is using the arguments, as you say.

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

--
Kees Cook