From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: "guennadi.liakhovetski@linux.intel.com"
<guennadi.liakhovetski@linux.intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"ryan.lee.maxim@gmail.com" <ryan.lee.maxim@gmail.com>,
Ryan Lee <RyanS.Lee@maximintegrated.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"sathya.prakash.m.r@intel.com" <sathya.prakash.m.r@intel.com>,
"yung-chuan.liao@linux.intel.com"
<yung-chuan.liao@linux.intel.com>
Subject: Re: [EXTERNAL] Re: [PATCH] ASoC: max98373: Mark cache dirty before entering sleep
Date: Mon, 27 Sep 2021 18:29:40 +0100 [thread overview]
Message-ID: <20210927172940.GH4199@sirena.org.uk> (raw)
In-Reply-To: <0af258d4-e33c-15ec-5dcc-a1c9961c0740@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On Mon, Sep 27, 2021 at 12:23:06PM -0500, Pierre-Louis Bossart wrote:
> On 9/27/21 12:10 PM, Mark Brown wrote:
> > A quick survey of other drivers suggests that this pattern should be
> > factored out into some helpers as it looks like there's several ways of
> > implementing it that look very similar but not quite the same...
> No disagreement here, we tried really hard to enforce a common pattern
> for suspend-resume, but i just noticed that the maxim amp driver is
> different on suspend (resume is consistent with the rest).
There seem to be several slightly different ways of writing what I think
is supposed to be the same thing in _io_init() too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-27 17:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 22:13 [PATCH] ASoC: max98373: Mark cache dirty before entering sleep Ryan Lee
2021-09-27 14:54 ` Pierre-Louis Bossart
2021-09-27 16:01 ` [EXTERNAL] " Ryan Lee
2021-09-27 16:06 ` Mark Brown
2021-09-27 16:48 ` Pierre-Louis Bossart
2021-09-27 17:10 ` Mark Brown
2021-09-27 17:23 ` Pierre-Louis Bossart
2021-09-27 17:29 ` Mark Brown [this message]
2021-09-28 16:43 ` Ryan Lee
2021-09-28 18:15 ` Pierre-Louis Bossart
2021-09-27 18:44 ` Ryan Lee
2021-09-27 19:34 ` Pierre-Louis Bossart
2021-09-27 22:43 ` Ryan Lee
2021-09-30 6:21 ` Ryan Lee
2021-09-30 13:29 ` Pierre-Louis Bossart
2021-09-30 23:31 ` Ryan Lee
2021-09-30 23:53 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927172940.GH4199@sirena.org.uk \
--to=broonie@kernel.org \
--cc=RyanS.Lee@maximintegrated.com \
--cc=alsa-devel@alsa-project.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox