From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7797C433F5 for ; Tue, 28 Sep 2021 05:58:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9281B6113E for ; Tue, 28 Sep 2021 05:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239289AbhI1F7p (ORCPT ); Tue, 28 Sep 2021 01:59:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:48784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239199AbhI1F6l (ORCPT ); Tue, 28 Sep 2021 01:58:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1997461266; Tue, 28 Sep 2021 05:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632808604; bh=9XYhxWHvugaXUYp0Mrx7sZwFT1FDnAgQlbvApNOr2+Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IDbTbR77lowQ2y9htl4J/sbn6KqjUvqZekyjAm8wYjt/QdCkzNErko4DiRpx6sr5v bh5G7/tuLopx3nfHvAeqqjdZMwrd+IKeFT5j5bi9yXmedYq3DR51Y9odX/CN3Z4JsC iMxWblqa2Yxc+UKULmal7Jo/XBA/UAEu4C0BU6sZuUyBS/E0Jv9MbVIXHwvkEifTm8 4pCQKwj8NAJ3NOR1mPy7jmN6yym49vUGA/WsuwGV6fx/k3qB1TvBpYn+a6bAQLyL5k mrDjid7AC8oZBZydkNYQzlDWqxt7sGVjd2ni1npb3Dim/vOYqbOcK9+eO7fA743ZT4 pwW3wl/Fl7uKQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nathan Chancellor , Marco Elver , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Nick Desaulniers , Arnd Bergmann , Andrew Morton , Linus Torvalds , Sasha Levin , masahiroy@kernel.org, michal.lkml@markovi.net, kasan-dev@googlegroups.com, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH AUTOSEL 5.14 40/40] kasan: always respect CONFIG_KASAN_STACK Date: Tue, 28 Sep 2021 01:55:24 -0400 Message-Id: <20210928055524.172051-40-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210928055524.172051-1-sashal@kernel.org> References: <20210928055524.172051-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor [ Upstream commit 19532869feb9b0a97d17ddc14609d1e53a5b60db ] Currently, the asan-stack parameter is only passed along if CFLAGS_KASAN_SHADOW is not empty, which requires KASAN_SHADOW_OFFSET to be defined in Kconfig so that the value can be checked. In RISC-V's case, KASAN_SHADOW_OFFSET is not defined in Kconfig, which means that asan-stack does not get disabled with clang even when CONFIG_KASAN_STACK is disabled, resulting in large stack warnings with allmodconfig: drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c:117:12: error: stack frame size (14400) exceeds limit (2048) in function 'lb035q02_connect' [-Werror,-Wframe-larger-than] static int lb035q02_connect(struct omap_dss_device *dssdev) ^ 1 error generated. Ensure that the value of CONFIG_KASAN_STACK is always passed along to the compiler so that these warnings do not happen when CONFIG_KASAN_STACK is disabled. Link: https://github.com/ClangBuiltLinux/linux/issues/1453 References: 6baec880d7a5 ("kasan: turn off asan-stack for clang-8 and earlier") Link: https://lkml.kernel.org/r/20210922205525.570068-1-nathan@kernel.org Signed-off-by: Nathan Chancellor Reviewed-by: Marco Elver Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Andrey Konovalov Cc: Dmitry Vyukov Cc: Nick Desaulniers Cc: Arnd Bergmann Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- scripts/Makefile.kasan | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan index 801c415bac59..b9e94c5e7097 100644 --- a/scripts/Makefile.kasan +++ b/scripts/Makefile.kasan @@ -33,10 +33,11 @@ else CFLAGS_KASAN := $(CFLAGS_KASAN_SHADOW) \ $(call cc-param,asan-globals=1) \ $(call cc-param,asan-instrumentation-with-call-threshold=$(call_threshold)) \ - $(call cc-param,asan-stack=$(stack_enable)) \ $(call cc-param,asan-instrument-allocas=1) endif +CFLAGS_KASAN += $(call cc-param,asan-stack=$(stack_enable)) + endif # CONFIG_KASAN_GENERIC ifdef CONFIG_KASAN_SW_TAGS -- 2.33.0