From: kernel test robot <lkp@intel.com>
To: Tony Lindgren <tony@atomide.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
0day robot <lkp@intel.com>
Subject: drivers/tty/serial/serial_core.c:621 uart_write_room() warn: unsigned 'ret' is never less than zero.
Date: Tue, 28 Sep 2021 19:47:08 +0800 [thread overview]
Message-ID: <202109281901.W4GmIDOG-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]
tree: https://github.com/0day-ci/linux/commits/Tony-Lindgren/Get-rid-of-pm_runtime_irq_safe-for-8250_omap/20210922-152808
head: 4456f28c1932b70461a0d8c45d4e863fa9d1be29
commit: 3c7e2a8d4353263d8c5607fc7eca5e4b009f45eb serial: core: Add new prep_tx for power management
date: 6 days ago
config: i386-randconfig-m021-20210927 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/tty/serial/serial_core.c:621 uart_write_room() warn: unsigned 'ret' is never less than zero.
Old smatch warnings:
drivers/tty/serial/serial_core.c:308 uart_shutdown() error: we previously assumed 'uport' could be null (see line 304)
drivers/tty/serial/serial_core.c:329 uart_shutdown() error: uninitialized symbol 'flags'.
drivers/tty/serial/serial_core.c:2753 iomem_base_show() warn: argument 3 to %lX specifier is cast from pointer
vim +/ret +621 drivers/tty/serial/serial_core.c
611
612 static unsigned int uart_write_room(struct tty_struct *tty)
613 {
614 struct uart_state *state = tty->driver_data;
615 struct uart_port *port;
616 unsigned long flags;
617 unsigned int ret;
618
619 port = uart_port_lock(state, flags);
620 ret = __uart_prep_tx(tty);
> 621 if (ret < 0) {
622 uart_port_unlock(port, flags);
623 return 0;
624 }
625
626 ret = uart_circ_chars_free(&state->xmit);
627 uart_port_unlock(port, flags);
628 return ret;
629 }
630
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40442 bytes --]
next reply other threads:[~2021-09-28 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 11:47 kernel test robot [this message]
2021-09-30 8:33 ` drivers/tty/serial/serial_core.c:621 uart_write_room() warn: unsigned 'ret' is never less than zero Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109281901.W4GmIDOG-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox