* [PATCH] sched/fair: removed useless update of p->recent_used_cpu
@ 2021-09-28 10:35 Vincent Guittot
2021-09-29 8:16 ` Mel Gorman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vincent Guittot @ 2021-09-28 10:35 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, dietmar.eggemann, rostedt, bsegall,
mgorman, bristot, linux-kernel
Cc: Vincent Guittot
Since commit 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu"),
p->recent_used_cpu is unconditionnaly set with prev.
Fixes: 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/fair.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e26d622762a9..bcb7617741c3 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6380,11 +6380,6 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target)
(available_idle_cpu(recent_used_cpu) || sched_idle_cpu(recent_used_cpu)) &&
cpumask_test_cpu(p->recent_used_cpu, p->cpus_ptr) &&
asym_fits_capacity(task_util, recent_used_cpu)) {
- /*
- * Replace recent_used_cpu with prev as it is a potential
- * candidate for the next wake:
- */
- p->recent_used_cpu = prev;
return recent_used_cpu;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sched/fair: removed useless update of p->recent_used_cpu
2021-09-28 10:35 [PATCH] sched/fair: removed useless update of p->recent_used_cpu Vincent Guittot
@ 2021-09-29 8:16 ` Mel Gorman
2021-10-01 15:05 ` [tip: sched/core] sched/fair: Removed " tip-bot2 for Vincent Guittot
2021-10-05 14:11 ` tip-bot2 for Vincent Guittot
2 siblings, 0 replies; 4+ messages in thread
From: Mel Gorman @ 2021-09-29 8:16 UTC (permalink / raw)
To: Vincent Guittot
Cc: mingo, peterz, juri.lelli, dietmar.eggemann, rostedt, bsegall,
bristot, linux-kernel
On Tue, Sep 28, 2021 at 12:35:44PM +0200, Vincent Guittot wrote:
> Since commit 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu"),
> p->recent_used_cpu is unconditionnaly set with prev.
>
>
> Fixes: 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu")
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: sched/core] sched/fair: Removed useless update of p->recent_used_cpu
2021-09-28 10:35 [PATCH] sched/fair: removed useless update of p->recent_used_cpu Vincent Guittot
2021-09-29 8:16 ` Mel Gorman
@ 2021-10-01 15:05 ` tip-bot2 for Vincent Guittot
2021-10-05 14:11 ` tip-bot2 for Vincent Guittot
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Vincent Guittot @ 2021-10-01 15:05 UTC (permalink / raw)
To: linux-tip-commits
Cc: Vincent Guittot, Peter Zijlstra (Intel), Mel Gorman, x86,
linux-kernel
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 959fc676791b91088b96341b644b92c8c52c7455
Gitweb: https://git.kernel.org/tip/959fc676791b91088b96341b644b92c8c52c7455
Author: Vincent Guittot <vincent.guittot@linaro.org>
AuthorDate: Tue, 28 Sep 2021 12:35:44 +02:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Fri, 01 Oct 2021 13:58:08 +02:00
sched/fair: Removed useless update of p->recent_used_cpu
Since commit 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu"),
p->recent_used_cpu is unconditionnaly set with prev.
Fixes: 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Mel Gorman <mgorman@suse.de>
Link: https://lkml.kernel.org/r/20210928103544.27489-1-vincent.guittot@linaro.org
---
kernel/sched/fair.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2ce015c..8943dbb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6380,11 +6380,6 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target)
(available_idle_cpu(recent_used_cpu) || sched_idle_cpu(recent_used_cpu)) &&
cpumask_test_cpu(p->recent_used_cpu, p->cpus_ptr) &&
asym_fits_capacity(task_util, recent_used_cpu)) {
- /*
- * Replace recent_used_cpu with prev as it is a potential
- * candidate for the next wake:
- */
- p->recent_used_cpu = prev;
return recent_used_cpu;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [tip: sched/core] sched/fair: Removed useless update of p->recent_used_cpu
2021-09-28 10:35 [PATCH] sched/fair: removed useless update of p->recent_used_cpu Vincent Guittot
2021-09-29 8:16 ` Mel Gorman
2021-10-01 15:05 ` [tip: sched/core] sched/fair: Removed " tip-bot2 for Vincent Guittot
@ 2021-10-05 14:11 ` tip-bot2 for Vincent Guittot
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for Vincent Guittot @ 2021-10-05 14:11 UTC (permalink / raw)
To: linux-tip-commits
Cc: Vincent Guittot, Peter Zijlstra (Intel), Mel Gorman, x86,
linux-kernel
The following commit has been merged into the sched/core branch of tip:
Commit-ID: a7ba894821b6ade7bb420455f87020b2838d6180
Gitweb: https://git.kernel.org/tip/a7ba894821b6ade7bb420455f87020b2838d6180
Author: Vincent Guittot <vincent.guittot@linaro.org>
AuthorDate: Tue, 28 Sep 2021 12:35:44 +02:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 05 Oct 2021 15:52:17 +02:00
sched/fair: Removed useless update of p->recent_used_cpu
Since commit 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu"),
p->recent_used_cpu is unconditionnaly set with prev.
Fixes: 89aafd67f28c ("sched/fair: Use prev instead of new target as recent_used_cpu")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Mel Gorman <mgorman@suse.de>
Link: https://lkml.kernel.org/r/20210928103544.27489-1-vincent.guittot@linaro.org
---
kernel/sched/fair.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c50ae23..2468d1d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6413,11 +6413,6 @@ static int select_idle_sibling(struct task_struct *p, int prev, int target)
(available_idle_cpu(recent_used_cpu) || sched_idle_cpu(recent_used_cpu)) &&
cpumask_test_cpu(p->recent_used_cpu, p->cpus_ptr) &&
asym_fits_capacity(task_util, recent_used_cpu)) {
- /*
- * Replace recent_used_cpu with prev as it is a potential
- * candidate for the next wake:
- */
- p->recent_used_cpu = prev;
return recent_used_cpu;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-05 14:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-28 10:35 [PATCH] sched/fair: removed useless update of p->recent_used_cpu Vincent Guittot
2021-09-29 8:16 ` Mel Gorman
2021-10-01 15:05 ` [tip: sched/core] sched/fair: Removed " tip-bot2 for Vincent Guittot
2021-10-05 14:11 ` tip-bot2 for Vincent Guittot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox