Re: [PATCH v4 06/15] ftrace: Use an opaque type for functions not callable from C

Josh Poimboeuf
2021-10-06T20:43:45Z

On Wed, Oct 06, 2021 at 10:45:41AM -0700, Sami Tolvanen wrote:
> On Wed, Oct 6, 2021 at 9:58 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Wed, 6 Oct 2021 09:31:04 -0700
> > Sami Tolvanen <samitolvanen@google.com> wrote:
> >
> > > > > On Thu, Sep 30, 2021 at 11:05:22AM -0700, Sami Tolvanen wrote:
> > > > > > With CONFIG_CFI_CLANG, the compiler changes function references to point
> > > > > > to the CFI jump table. As ftrace_call, ftrace_regs_call, and mcount_call
> > > > > > are not called from C, use DECLARE_ASM_FUNC_SYMBOL to declare them.
> > > >
> > > > "not called from C" is a bit confusing.
> > >
> > > Any thoughts on how to make this less confusing?
> >
> > "Not called by C code, but injected by the compiler."
> >
> > ?
>
> Sure, sounds good to me. I'll update this in v5.

"injected by the compiler" sounds even more confusing. It almost sounds
like those functions are generated by GCC, which they are most
definitely not.

--
Josh