public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jules Irenge <jbi.octave@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
	Cong Wang <cong.wang@bytedance.com>,
	Eric Dumazet <edumazet@google.com>,
	Rao Shoaib <Rao.Shoaib@oracle.com>,
	Jiang Wang <jiang.wang@bytedance.com>,
	Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Subject: [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq_stop()
Date: Sat,  2 Oct 2021 00:49:37 +0100	[thread overview]
Message-ID: <20211001234938.14806-1-jbi.octave@gmail.com> (raw)

Sparse reports a warning at bpf_iter_unix_seq_stop()
The root cause is a missing annotation at bpf_iter_unix_seq_stop()

Add the missing __releases(unix_table_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/unix/af_unix.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index efac5989edb5..9838d4d855e0 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v)
 }
 
 static void bpf_iter_unix_seq_stop(struct seq_file *seq, void *v)
+	__releases(unix_table_lock)
 {
 	struct bpf_iter_meta meta;
 	struct bpf_prog *prog;
-- 
2.32.0


             reply	other threads:[~2021-10-01 23:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 23:49 Jules Irenge [this message]
2021-10-02  1:04 ` [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq_stop() Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001234938.14806-1-jbi.octave@gmail.com \
    --to=jbi.octave@gmail.com \
    --cc=Rao.Shoaib@oracle.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=cong.wang@bytedance.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiang.wang@bytedance.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox