From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2EFC433F5 for ; Fri, 1 Oct 2021 23:49:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E3D361A8E for ; Fri, 1 Oct 2021 23:49:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232085AbhJAXvf (ORCPT ); Fri, 1 Oct 2021 19:51:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230368AbhJAXvd (ORCPT ); Fri, 1 Oct 2021 19:51:33 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05674C061775 for ; Fri, 1 Oct 2021 16:49:49 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id m22so12390091wrb.0 for ; Fri, 01 Oct 2021 16:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YIEsVF9+Cz+d1jK4k/hfEQTb1VC/M0tqWGPuXQp3AVc=; b=iarDf0OEMpwYPvVDTlxz/p+lSsjGK9ZgI+M9EBRhABW+xI0bwqg3TZU1CrBTIdnKMG JRdnUADnNQfn2SV5TNt8yd5oDV02pFmyr1bh+OHydCgCJSwU0iYwoyHaKEfVxn8I03SL +1eBonOku2f2AxOEB00KpZeSP7DoiDH7AcVw/qS4dze+9CbhXsYYHIDwgGuPSMAxAuep QnCQH05A63mzo5H7rRuIKu5vfQgz2accT4r9BtDSHlwCPBjBSaLjQHruNXmCQn1BFZ2A Dv3k5Gd8QDiV5ZK6q5F4TvQ2R0MrHb9wK155Q0l2ixA2/LcF9OohmPE4StjgMKLABa/H 19/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YIEsVF9+Cz+d1jK4k/hfEQTb1VC/M0tqWGPuXQp3AVc=; b=bNUaphkyQONW6B+0nAkma+prwaSOWV7x9OatDX5gTcw/4Xjqt3imbrZehi43jwpm8I at9DO+Bm3iVmALAmq5AHbtFRQHAjxNR6qrRrDfdKDaujfj5I7JJZ/sHSWTsngeDWLWhy lzXlSVfQxiYsb7uc/h9e8o4NHlUS4Fhtv53sSFunRRWG/BCwTO90lzHbB3f5vPcITcCJ qiiSw1yveu24SGgbg34zuvysnDJG6gUTwaM/uiIm7v4DkKd+ZrD1rKpVDvS0cmPyLbuh MNsCiT81YtrHvnIENsy3jzxx7ZgxlEsh2+I7LvbGBIRMlNGdO65tkhQsFjG7opAA839W nxlQ== X-Gm-Message-State: AOAM533f8Jo+oFqcMnDOEeTiqAhQiddiLM9wIw8CUrSaBzPMxjtajd9W hmjld9NU6YU2BwcxUJ9dXpS1j3dXzezTeic= X-Google-Smtp-Source: ABdhPJy9reDOzOL4LfHVl1QUKbSnSEvXX3F7401/QaRhkT/w1HY++FVvLEVmnDAVEglkQhWLEJuq1w== X-Received: by 2002:a05:6000:144d:: with SMTP id v13mr616891wrx.303.1633132187432; Fri, 01 Oct 2021 16:49:47 -0700 (PDT) Received: from localhost.localdomain (88-108-171-137.dynamic.dsl.as9105.com. [88.108.171.137]) by smtp.gmail.com with ESMTPSA id c4sm6943738wrt.23.2021.10.01.16.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 16:49:47 -0700 (PDT) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: Jules Irenge , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Al Viro , Cong Wang , Eric Dumazet , Rao Shoaib , Jiang Wang , Kuniyuki Iwashima Subject: [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq_stop() Date: Sat, 2 Oct 2021 00:49:37 +0100 Message-Id: <20211001234938.14806-1-jbi.octave@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at bpf_iter_unix_seq_stop() The root cause is a missing annotation at bpf_iter_unix_seq_stop() Add the missing __releases(unix_table_lock) annotation Signed-off-by: Jules Irenge --- net/unix/af_unix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index efac5989edb5..9838d4d855e0 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v) } static void bpf_iter_unix_seq_stop(struct seq_file *seq, void *v) + __releases(unix_table_lock) { struct bpf_iter_meta meta; struct bpf_prog *prog; -- 2.32.0