Re: [PATCH v3 5/6] MIPS: implement architecture-specific 'pci_remap_iospace()'

Thomas Bogendoerfer
2021-10-03T16:09:59Z

On Sat, Sep 25, 2021 at 10:32:23PM +0200, Sergio Paracuellos wrote:
> To make PCI IO work we need to properly virtually map IO cpu physical address
> and set this virtual address as the address of the first PCI IO port which
> is set using function 'set_io_port_base()'.
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> arch/mips/include/asm/pci.h | 2 ++
> arch/mips/pci/pci-generic.c | 14 ++++++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/arch/mips/include/asm/pci.h b/arch/mips/include/asm/pci.h
> index 9ffc8192adae..35270984a5f0 100644
> --- a/arch/mips/include/asm/pci.h
> +++ b/arch/mips/include/asm/pci.h
> @@ -20,6 +20,8 @@
> #include <linux/list.h>
> #include <linux/of.h>
>
> +#define pci_remap_iospace pci_remap_iospace
> +
> #ifdef CONFIG_PCI_DRIVERS_LEGACY
>
> /*
> diff --git a/arch/mips/pci/pci-generic.c b/arch/mips/pci/pci-generic.c
> index 95b00017886c..18eb8a453a86 100644
> --- a/arch/mips/pci/pci-generic.c
> +++ b/arch/mips/pci/pci-generic.c
> @@ -46,3 +46,17 @@ void pcibios_fixup_bus(struct pci_bus *bus)
> {
> pci_read_bridge_bases(bus);
> }
> +
> +int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr)
> +{
> + unsigned long vaddr;
> +
> + if (res->start != 0) {
> + WARN_ONCE(1, "resource start address is not zero\n");
> + return -ENODEV;
> + }
> +
> + vaddr = (unsigned long)ioremap(phys_addr, resource_size(res));
> + set_io_port_base(vaddr);
> + return 0;
> +}

Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]