From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4978C433F5 for ; Sun, 3 Oct 2021 16:09:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB1ED61AFB for ; Sun, 3 Oct 2021 16:09:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231205AbhJCQL0 (ORCPT ); Sun, 3 Oct 2021 12:11:26 -0400 Received: from elvis.franken.de ([193.175.24.41]:57367 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbhJCQLW (ORCPT ); Sun, 3 Oct 2021 12:11:22 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mX43M-0005aq-03; Sun, 03 Oct 2021 18:09:28 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D5F13C1D2B; Sun, 3 Oct 2021 18:09:05 +0200 (CEST) Date: Sun, 3 Oct 2021 18:09:05 +0200 From: Thomas Bogendoerfer To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Russell King , Catalin Marinas , Will Deacon , Marc Zyngier , Rob Herring , Frank Rowand , "moderated list:ARM SUB-ARCHITECTURES" , "open list:MIPS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Subject: Re: [PATCH v3 01/14] MIPS: BMIPS: Remove use of irq_cpu_offline Message-ID: <20211003160905.GD4984@alpha.franken.de> References: <20210928182139.652896-1-f.fainelli@gmail.com> <20210928182139.652896-2-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210928182139.652896-2-f.fainelli@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 28, 2021 at 11:21:26AM -0700, Florian Fainelli wrote: > irq_cpu_offline() is only used by MIPS and we should instead use > irq_migrate_all_off_this_cpu(). This will be helpful in order to remove > drivers/irqchip/irq-bcm7038-l1.c irq_cpu_offline callback which would > have got in the way of making this driver modular. > > Suggested-by: Thomas Gleixner > Signed-off-by: Florian Fainelli > --- > arch/mips/Kconfig | 1 + > arch/mips/kernel/smp-bmips.c | 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 771ca53af06d..2c03b27cec02 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -1782,6 +1782,7 @@ config CPU_BMIPS > select CPU_HAS_PREFETCH > select CPU_SUPPORTS_CPUFREQ > select MIPS_EXTERNAL_TIMER > + select GENERIC_IRQ_MIGRATION if HOTPLUG_CPU > help > Support for BMIPS32/3300/4350/4380 and BMIPS5000 processors. > > diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c > index b6ef5f7312cf..f5d7bfa3472a 100644 > --- a/arch/mips/kernel/smp-bmips.c > +++ b/arch/mips/kernel/smp-bmips.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -373,7 +374,7 @@ static int bmips_cpu_disable(void) > > set_cpu_online(cpu, false); > calculate_cpu_foreign_map(); > - irq_cpu_offline(); > + irq_migrate_all_off_this_cpu(); > clear_c0_status(IE_IRQ5); > > local_flush_tlb_all(); Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]