From: Gaston Gonzalez <gascoar@gmail.com>
To: linux-staging@lists.linux.dev
Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org,
stefan.wahren@i2se.com, arnd@arndb.de, dan.carpenter@oracle.com,
ojaswin98@gmail.com, amarjargal16@gmail.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, gascoar@gmail.com
Subject: [PATCH 9/9] staging: vchiq_core: fix quoted strings split across lines
Date: Sun, 3 Oct 2021 16:58:02 -0300 [thread overview]
Message-ID: <20211003195758.36572-10-gascoar@gmail.com> (raw)
In-Reply-To: <20211003195758.36572-1-gascoar@gmail.com>
Quoted strings should not be split across lines. As put it in [1]:
"never break user-visible strings such as printk messages because that
breaks the ability to grep for them."
While at it, fix the alignment of the arguments in the sentence.
Note: as the line now is:
vchiq_loud_error("%d: service %d (%c%c%c%c) version mismatch - local (%d, min %d) vs. remote (%d, min %d)",
checkpatch.pl emits a CHECK: line length of 123 exceeds 100 columns.
But now the string is grep-able and the whole function call is more clear.
Reported by checkpatch.pl
[1] Documentation/process/coding-style.rst
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 416110bf20fa..fa65a99ae54a 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -1499,13 +1499,9 @@ parse_open(struct vchiq_state *state, struct vchiq_header *header)
if ((service->version < version_min) || (version < service->version_min)) {
/* Version mismatch */
vchiq_loud_error_header();
- vchiq_loud_error("%d: service %d (%c%c%c%c) "
- "version mismatch - local (%d, min %d)"
- " vs. remote (%d, min %d)",
- state->id, service->localport,
- VCHIQ_FOURCC_AS_4CHARS(fourcc),
- service->version, service->version_min,
- version, version_min);
+ vchiq_loud_error("%d: service %d (%c%c%c%c) version mismatch - local (%d, min %d) vs. remote (%d, min %d)",
+ state->id, service->localport, VCHIQ_FOURCC_AS_4CHARS(fourcc),
+ service->version, service->version_min, version, version_min);
vchiq_loud_error_footer();
vchiq_service_put(service);
service = NULL;
--
2.33.0
prev parent reply other threads:[~2021-10-03 20:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 19:57 [PATCH 0/9] staging: vchiq_core: various style cleanups Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 1/9] staging: vchiq_core: cleanup blank lines Gaston Gonzalez
2021-10-04 6:55 ` Dan Carpenter
2021-10-04 19:55 ` Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 2/9] staging: vchiq_core: cleanup code alignment issues Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 3/9] staging: vchiq_core.h: fix CamelCase in function declaration Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 4/9] staging: vchiq_core.h: use preferred kernel types Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 5/9] staging: vchiq: drop trailing semicolon in macro definition Gaston Gonzalez
2021-10-03 19:57 ` [PATCH 6/9] staging: vchiq_core: drop extern prefix in function declarations Gaston Gonzalez
2021-10-03 19:58 ` [PATCH 7/9] staging: vchiq_core: cleanup lines that end with '(' or '[' Gaston Gonzalez
2021-10-03 19:58 ` [PATCH 8/9] staging: vchiq_core: cleanup unnecessary blank line Gaston Gonzalez
2021-10-03 19:58 ` Gaston Gonzalez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211003195758.36572-10-gascoar@gmail.com \
--to=gascoar@gmail.com \
--cc=amarjargal16@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox