From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6E5C4332F for ; Mon, 4 Oct 2021 13:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08C08611C5 for ; Mon, 4 Oct 2021 13:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237396AbhJDNlM (ORCPT ); Mon, 4 Oct 2021 09:41:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:53350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238077AbhJDNjB (ORCPT ); Mon, 4 Oct 2021 09:39:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E265C61B43; Mon, 4 Oct 2021 13:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633353484; bh=+nmn2T/gLkpxJZ3Hz0C18UkyZUU9sXotryoqJch8cxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lJY2EbBuQj1flo2yD0iheUGdsrmVz0E5Vdjt/8vBeO53P8Y5g/x64lM/suXflrQlV e5170xrowGc4/br7pjatCbJzkRuS9aubPehp1iyZQd8kImDl6zedLR7HwYUJwDls3a Kowe58TyD4MEkF5I0bBmEvaByO/5MxcLP05a9xeM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Christian=20K=C3=B6nig?= , Nirmoy Das Subject: [PATCH 5.14 147/172] debugfs: debugfs_create_file_size(): use IS_ERR to check for error Date: Mon, 4 Oct 2021 14:53:17 +0200 Message-Id: <20211004125049.716004118@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211004125044.945314266@linuxfoundation.org> References: <20211004125044.945314266@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nirmoy Das commit af505cad9567f7a500d34bf183696d570d7f6810 upstream. debugfs_create_file() returns encoded error so use IS_ERR for checking return value. Reviewed-by: Christian König Signed-off-by: Nirmoy Das Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL") Cc: stable Link: https://lore.kernel.org/r/20210902102917.2233-1-nirmoy.das@amd.com Signed-off-by: Greg Kroah-Hartman --- fs/debugfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -528,7 +528,7 @@ void debugfs_create_file_size(const char { struct dentry *de = debugfs_create_file(name, mode, parent, data, fops); - if (de) + if (!IS_ERR(de)) d_inode(de)->i_size = file_size; } EXPORT_SYMBOL_GPL(debugfs_create_file_size);