From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND] mfd: hi6421-spmi-pmic: cleanup drvdata
Date: Tue, 5 Oct 2021 09:56:03 +0200 [thread overview]
Message-ID: <20211005095603.0e204776@coco.lan> (raw)
In-Reply-To: <YVwD2sPZMCtwP9yf@google.com>
Em Tue, 5 Oct 2021 08:50:50 +0100
Lee Jones <lee.jones@linaro.org> escreveu:
> On Wed, 15 Sep 2021, Mauro Carvalho Chehab wrote:
>
> > There are lots of fields at struct hi6421_spmi_pmic that aren't
> > used. In a matter of fact, only regmap is needed.
> >
> > So, drop the struct as a hole, and set just the regmap as
> > the drvdata.
> >
> > Acked-by: Mark Brown <broonie@kernel.org>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > ---
> > drivers/mfd/hi6421-spmi-pmic.c | 16 +++++----------
> > drivers/misc/hi6421v600-irq.c | 9 ++++-----
> > drivers/regulator/hi6421v600-regulator.c | 10 +++++-----
> > include/linux/mfd/hi6421-spmi-pmic.h | 25 ------------------------
> > 4 files changed, 14 insertions(+), 46 deletions(-)
> > delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h
>
> For my own reference (apply this as-is to your sign-off block):
>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
>
> I intend to take this with a Misc Ack.
Hi Lee,
Greg already gave you:
https://lore.kernel.org/all/YVLA14jbwqXjNM2f@kroah.com/
Regards,
Mauro
next prev parent reply other threads:[~2021-10-05 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 12:47 [PATCH v2 RESEND] mfd: hi6421-spmi-pmic: cleanup drvdata Mauro Carvalho Chehab
2021-10-05 7:50 ` Lee Jones
2021-10-05 7:56 ` Mauro Carvalho Chehab [this message]
2021-10-05 8:11 ` Lee Jones
2021-10-05 8:46 ` Mauro Carvalho Chehab
2021-10-06 7:57 ` [GIT PULL] Immutable branch between MFD, Misc and Regulator due for the v5.16 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005095603.0e204776@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox