From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A67C433EF for ; Tue, 5 Oct 2021 07:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8E9F61184 for ; Tue, 5 Oct 2021 07:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233465AbhJEH62 (ORCPT ); Tue, 5 Oct 2021 03:58:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:39492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233612AbhJEH55 (ORCPT ); Tue, 5 Oct 2021 03:57:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B446961350; Tue, 5 Oct 2021 07:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633420567; bh=f4gsbsUJ2pbvz6Vm0qN214XBzGKbfjvTDyCDkH9qwoU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jr0uAPEXaN1ov5aY1GCXK4ansIV4xeQfmIv3dWlzxw+RKXAoYflkVVtsEW+QkLn9i HoXNedAH5S4LUu787uOK/T6ITBB3sozWJhgDKVB/wW4sgnfNclbRJhIb/JTav+mOoa qFMoPvursQplbFXEaRSU/zmIRnQUp6ilmv+sdINxLTZ0dfyMDxVWY9xmuxgPgOuS6y ezvhoaJ4cJLGpifj2IxbDEO5kRjuYFOC7J3s2Q08XEXYPo7V0Utu55n0cozKNebRNs vAb0Pze/6bXxz08oVdPvpQJoOZ49bhLqUJd7RpzAabo/c1RoYUfPYJQi8owr8N9FA9 qiRYYsp4W0QQA== Date: Tue, 5 Oct 2021 09:56:03 +0200 From: Mauro Carvalho Chehab To: Lee Jones Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Arnd Bergmann , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 RESEND] mfd: hi6421-spmi-pmic: cleanup drvdata Message-ID: <20211005095603.0e204776@coco.lan> In-Reply-To: References: X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, 5 Oct 2021 08:50:50 +0100 Lee Jones escreveu: > On Wed, 15 Sep 2021, Mauro Carvalho Chehab wrote: > > > There are lots of fields at struct hi6421_spmi_pmic that aren't > > used. In a matter of fact, only regmap is needed. > > > > So, drop the struct as a hole, and set just the regmap as > > the drvdata. > > > > Acked-by: Mark Brown > > Signed-off-by: Mauro Carvalho Chehab > > --- > > drivers/mfd/hi6421-spmi-pmic.c | 16 +++++---------- > > drivers/misc/hi6421v600-irq.c | 9 ++++----- > > drivers/regulator/hi6421v600-regulator.c | 10 +++++----- > > include/linux/mfd/hi6421-spmi-pmic.h | 25 ------------------------ > > 4 files changed, 14 insertions(+), 46 deletions(-) > > delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h > > For my own reference (apply this as-is to your sign-off block): > > Acked-for-MFD-by: Lee Jones > > I intend to take this with a Misc Ack. Hi Lee, Greg already gave you: https://lore.kernel.org/all/YVLA14jbwqXjNM2f@kroah.com/ Regards, Mauro