From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/5] irq_work: Ensure that irq_work runs in in-IRQ context.
Date: Tue, 5 Oct 2021 22:11:03 +0200 [thread overview]
Message-ID: <20211005201103.GB174703@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20211005154827.h2pna3vfqbo7icjn@linutronix.de>
On Tue, Oct 05, 2021 at 05:48:27PM +0200, Sebastian Andrzej Siewior wrote:
> On 2021-09-27 23:19:16 [+0200], To linux-kernel@vger.kernel.org wrote:
> > The irq-work callback should be invoked in hardirq context and some
> > callbacks rely on this behaviour. At the time irq_work_run_list()
> > interrupts should be disabled but the important part is that the
> > callback is invoked from a in-IRQ context.
> > The "disabled interrupts" check can be satisfied by disabling interrupts
> > from a kworker which is not the intended context.
> >
> > Ensure that the callback is invoked from hardirq context and not just
> > with disabled interrupts.
>
> As noted by lkp, this triggers from smpcfd_dying_cpu().
It lives then? I don't think I've had it report on my trees in about a
week :/
> Do we care enough to change this or should I rather drop this one?
Drop it for now I suppose...
next prev parent reply other threads:[~2021-10-05 20:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 21:19 [PATCH 0/5] irq_work: PREEMPT_RT bits Sebastian Andrzej Siewior
2021-09-27 21:19 ` [PATCH 1/5] sched/rt: Annotate the RT balancing logic irqwork as IRQ_WORK_HARD_IRQ Sebastian Andrzej Siewior
2021-09-27 21:19 ` [PATCH 2/5] irq_work: Ensure that irq_work runs in in-IRQ context Sebastian Andrzej Siewior
2021-10-05 15:48 ` Sebastian Andrzej Siewior
2021-10-05 20:11 ` Peter Zijlstra [this message]
2021-09-27 21:19 ` [PATCH 3/5] irq_work: Allow irq_work_sync() to sleep if irq_work() no IRQ support Sebastian Andrzej Siewior
2021-09-27 21:19 ` [PATCH 4/5] irq_work: Handle some irq_work in SOFTIRQ on PREEMPT_RT Sebastian Andrzej Siewior
2021-09-30 9:07 ` Peter Zijlstra
2021-09-30 9:53 ` Sebastian Andrzej Siewior
2021-09-30 14:39 ` Peter Zijlstra
2021-09-30 16:38 ` Sebastian Andrzej Siewior
2021-10-01 10:32 ` Peter Zijlstra
2021-10-01 12:08 ` Sebastian Andrzej Siewior
2021-10-01 13:40 ` Peter Zijlstra
2021-09-27 21:19 ` [PATCH 5/5] irq_work: Also rcuwait for !IRQ_WORK_HARD_IRQ " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005201103.GB174703@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox