Re: [PATCH v1 3/4] ASoC: Intel: bytcr_rt5640: use devm_clk_get_optional() for mclk

Andy Shevchenko
2021-10-06T16:24:47Z

On Wed, Oct 06, 2021 at 10:54:12AM -0500, Pierre-Louis Bossart wrote:
> On 10/6/21 10:04 AM, Andy Shevchenko wrote:
> > The devm_clk_get_optional() helper returns NULL when devm_clk_get()
> > returns -ENOENT. This makes things slightly cleaner. The added benefit
> > is mostly cosmetic.

...

> > if (SND_SOC_DAPM_EVENT_ON(event)) {
> > - if (byt_rt5640_quirk & BYT_RT5640_MCLK_EN) {
>
> same comment as for rt5651, I don't see the point of removing the test
> on this quirk?

Same answers.

--
With Best Regards,
Andy Shevchenko