From: Brent Lu <brent.lu@intel.com>
To: alsa-devel@alsa-project.org
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Brent Lu <brent.lu@intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Yong Zhi <yong.zhi@intel.com>,
Vamshi Krishna Gopal <vamshi.krishna.gopal@intel.com>,
linux-kernel@vger.kernel.org, Rander Wang <rander.wang@intel.com>,
Bard Liao <bard.liao@intel.com>,
Malik_Hsu <malik_hsu@wistron.corp-partner.google.com>,
Libin Yang <libin.yang@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Paul Olaru <paul.olaru@oss.nxp.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Mac Chiang <mac.chiang@intel.com>,
Gongjun Song <gongjun.song@intel.com>
Subject: [PATCH 1/3] ASoC: soc-acpi: add alternative id field for machine driver matching
Date: Thu, 7 Oct 2021 00:18:03 +0800 [thread overview]
Message-ID: <20211006161805.938950-2-brent.lu@intel.com> (raw)
In-Reply-To: <20211006161805.938950-1-brent.lu@intel.com>
Current design to support second headphone driver in the same machine
driver is to duplicate the entries in snd_soc_acpi_mach array and
board configs in machine driver. We can avoid this by adding an id_alt
field in snd_soc_acpi_mach structure to specify alternative ACPI HIDs
for machine driver enumeration and leave the codec type detection to
machine driver if necessary.
Signed-off-by: Brent Lu <brent.lu@intel.com>
---
include/sound/soc-acpi.h | 2 ++
sound/soc/soc-acpi.c | 21 ++++++++++++++++++++-
2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/include/sound/soc-acpi.h b/include/sound/soc-acpi.h
index 2f3fa385c092..fcf6bae9f9d7 100644
--- a/include/sound/soc-acpi.h
+++ b/include/sound/soc-acpi.h
@@ -129,6 +129,7 @@ struct snd_soc_acpi_link_adr {
* all firmware/topology related fields.
*
* @id: ACPI ID (usually the codec's) used to find a matching machine driver.
+ * @id_alt: array of ACPI IDs used as an alternative of id field.
* @link_mask: describes required board layout, e.g. for SoundWire.
* @links: array of link _ADR descriptors, null terminated.
* @drv_name: machine driver name
@@ -146,6 +147,7 @@ struct snd_soc_acpi_link_adr {
/* Descriptor for SST ASoC machine driver */
struct snd_soc_acpi_mach {
const u8 id[ACPI_ID_LEN];
+ struct snd_soc_acpi_codecs *id_alt;
const u32 link_mask;
const struct snd_soc_acpi_link_adr *links;
const char *drv_name;
diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c
index 395229bf5c51..ab67d640c20f 100644
--- a/sound/soc/soc-acpi.c
+++ b/sound/soc/soc-acpi.c
@@ -8,6 +8,25 @@
#include <linux/module.h>
#include <sound/soc-acpi.h>
+static bool snd_soc_acpi_id_present(struct snd_soc_acpi_mach *machine)
+{
+ struct snd_soc_acpi_codecs *id_alt = machine->id_alt;
+ int i;
+
+ if (acpi_dev_present(machine->id, NULL, -1))
+ return true;
+
+ if (id_alt == NULL)
+ return false;
+
+ for (i = 0; i < id_alt->num_codecs; i++) {
+ if (acpi_dev_present(id_alt->codecs[i], NULL, -1))
+ return true;
+ }
+
+ return false;
+}
+
struct snd_soc_acpi_mach *
snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
{
@@ -15,7 +34,7 @@ snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
struct snd_soc_acpi_mach *mach_alt;
for (mach = machines; mach->id[0]; mach++) {
- if (acpi_dev_present(mach->id, NULL, -1)) {
+ if (snd_soc_acpi_id_present(mach) != false) {
if (mach->machine_quirk) {
mach_alt = mach->machine_quirk(mach);
if (!mach_alt)
--
2.25.1
next prev parent reply other threads:[~2021-10-06 16:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 16:18 [PATCH 0/3] Multiple headphone codec driver support Brent Lu
2021-10-06 16:18 ` Brent Lu [this message]
2021-10-06 16:44 ` [PATCH 1/3] ASoC: soc-acpi: add alternative id field for machine driver matching Andy Shevchenko
2021-10-06 16:50 ` Pierre-Louis Bossart
2021-10-06 16:18 ` [PATCH 2/3] ASoC: Intel: sof_rt5682: detect codec variant in probe function Brent Lu
2021-10-06 16:18 ` [PATCH 3/3] ASoC: Intel: sof_rt5682: use id_alt to enumerate rt5682s Brent Lu
2021-10-06 16:46 ` Andy Shevchenko
2021-10-06 17:18 ` Hans de Goede
2021-10-06 17:24 ` Pierre-Louis Bossart
2021-10-07 2:46 ` Liao, Bard
2021-10-07 13:49 ` Lu, Brent
2021-10-06 18:34 ` Curtis Malainey
2021-10-06 18:43 ` Pierre-Louis Bossart
2021-10-06 19:21 ` Curtis Malainey
2021-10-06 19:58 ` Pierre-Louis Bossart
2021-10-06 20:07 ` Curtis Malainey
2021-10-06 16:50 ` [PATCH 0/3] Multiple headphone codec driver support Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006161805.938950-2-brent.lu@intel.com \
--to=brent.lu@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=cujomalainey@chromium.org \
--cc=gongjun.song@intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=libin.yang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=malik_hsu@wistron.corp-partner.google.com \
--cc=paul.olaru@oss.nxp.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox