[PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH
@ 2021-10-06  9:34 Lukas Bulwahn
  2021-10-06 13:29 ` kernel test robot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2021-10-06  9:34 UTC (permalink / raw)
  To: Dan Williams, Vinod Koul; +Cc: kernel-janitors, linux-kernel, Lukas Bulwahn

Commit b802c8410ca9 ("async_tx: deprecate broken support for channel
switching") in 2017 intended to "prevent async_tx from using an offload
engine if the channel switching capability is enabled" by adding a
suitable ifdef on the corresponding config.

The config for determining if  the channel switching capability is
enabled is called CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH, however
the ifdef falsely refers to CONFIG_ASYNC_TX_CHANNEL_SWITCH (note the
missing "ENABLE").

Correct the name of the config to the intended one.

Fixes: b802c8410ca9 ("async_tx: deprecate broken support for channel switching")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 include/linux/async_tx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/async_tx.h b/include/linux/async_tx.h
index 5cc73d7e5b52..8c7b940d9912 100644
--- a/include/linux/async_tx.h
+++ b/include/linux/async_tx.h
@@ -74,7 +74,7 @@ struct async_submit_ctl {
 	void *scribble;
 };

-#if defined(CONFIG_DMA_ENGINE) && !defined(CONFIG_ASYNC_TX_CHANNEL_SWITCH)
+#if defined(CONFIG_DMA_ENGINE) && !defined(CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH)
 #define async_tx_issue_pending_all dma_issue_pending_all

 /**
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH
  2021-10-06  9:34 [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH Lukas Bulwahn
@ 2021-10-06 13:29 ` kernel test robot
  2021-10-06 20:44 ` kernel test robot
  2021-10-06 20:51 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-10-06 13:29 UTC (permalink / raw)
  To: Lukas Bulwahn, Dan Williams, Vinod Koul
  Cc: kbuild-all, kernel-janitors, linux-kernel, Lukas Bulwahn

[-- Attachment #1: Type: text/plain, Size: 3594 bytes --]

Hi Lukas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.15-rc3 next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lukas-Bulwahn/async_tx-correct-reference-to-ASYNC_TX_ENABLE_CHANNEL_SWITCH/20211006-173543
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 02d5e016800d082058b3d3b7c3ede136cdc6ddcb
config: riscv-buildonly-randconfig-r002-20211004 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/feea9903edb75548c8beb73119676b95ca4f08ef
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lukas-Bulwahn/async_tx-correct-reference-to-ASYNC_TX_ENABLE_CHANNEL_SWITCH/20211006-173543
        git checkout feea9903edb75548c8beb73119676b95ca4f08ef
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> crypto/async_tx/async_tx.c:43:1: warning: no previous prototype for '__async_tx_find_channel' [-Wmissing-prototypes]
      43 | __async_tx_find_channel(struct async_submit_ctl *submit,
         | ^~~~~~~~~~~~~~~~~~~~~~~


vim +/__async_tx_find_channel +43 crypto/async_tx/async_tx.c

af1f951eb6ef27 Dan Williams 2009-08-29  35  
9bc89cd82d6f88 Dan Williams 2007-01-02  36  /**
47437b2c9a6431 Dan Williams 2008-02-02  37   * __async_tx_find_channel - find a channel to carry out the operation or let
9bc89cd82d6f88 Dan Williams 2007-01-02  38   *	the transaction execute synchronously
a08abd8ca890a3 Dan Williams 2009-06-03  39   * @submit: transaction dependency and submission modifiers
9bc89cd82d6f88 Dan Williams 2007-01-02  40   * @tx_type: transaction type
9bc89cd82d6f88 Dan Williams 2007-01-02  41   */
9bc89cd82d6f88 Dan Williams 2007-01-02  42  struct dma_chan *
a08abd8ca890a3 Dan Williams 2009-06-03 @43  __async_tx_find_channel(struct async_submit_ctl *submit,
9bc89cd82d6f88 Dan Williams 2007-01-02  44  			enum dma_transaction_type tx_type)
9bc89cd82d6f88 Dan Williams 2007-01-02  45  {
a08abd8ca890a3 Dan Williams 2009-06-03  46  	struct dma_async_tx_descriptor *depend_tx = submit->depend_tx;
a08abd8ca890a3 Dan Williams 2009-06-03  47  
9bc89cd82d6f88 Dan Williams 2007-01-02  48  	/* see if we can keep the chain on one channel */
9bc89cd82d6f88 Dan Williams 2007-01-02  49  	if (depend_tx &&
9bc89cd82d6f88 Dan Williams 2007-01-02  50  	    dma_has_cap(tx_type, depend_tx->chan->device->cap_mask))
9bc89cd82d6f88 Dan Williams 2007-01-02  51  		return depend_tx->chan;
729b5d1b8ec72c Dan Williams 2009-03-25  52  	return async_dma_find_channel(tx_type);
9bc89cd82d6f88 Dan Williams 2007-01-02  53  }
47437b2c9a6431 Dan Williams 2008-02-02  54  EXPORT_SYMBOL_GPL(__async_tx_find_channel);
9bc89cd82d6f88 Dan Williams 2007-01-02  55  #endif
9bc89cd82d6f88 Dan Williams 2007-01-02  56  
19242d7233df7d Dan Williams 2008-04-17  57  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27607 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH
  2021-10-06  9:34 [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH Lukas Bulwahn
  2021-10-06 13:29 ` kernel test robot
@ 2021-10-06 20:44 ` kernel test robot
  2021-10-06 20:51 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-10-06 20:44 UTC (permalink / raw)
  To: Lukas Bulwahn, Dan Williams, Vinod Koul
  Cc: llvm, kbuild-all, kernel-janitors, linux-kernel, Lukas Bulwahn

[-- Attachment #1: Type: text/plain, Size: 3826 bytes --]

Hi Lukas,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.15-rc3 next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lukas-Bulwahn/async_tx-correct-reference-to-ASYNC_TX_ENABLE_CHANNEL_SWITCH/20211006-173543
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 02d5e016800d082058b3d3b7c3ede136cdc6ddcb
config: x86_64-buildonly-randconfig-r004-20211006 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c0039de2953d15815448b4b3c3bafb45607781e0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/feea9903edb75548c8beb73119676b95ca4f08ef
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lukas-Bulwahn/async_tx-correct-reference-to-ASYNC_TX_ENABLE_CHANNEL_SWITCH/20211006-173543
        git checkout feea9903edb75548c8beb73119676b95ca4f08ef
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> crypto/async_tx/async_tx.c:43:1: error: no previous prototype for function '__async_tx_find_channel' [-Werror,-Wmissing-prototypes]
   __async_tx_find_channel(struct async_submit_ctl *submit,
   ^
   crypto/async_tx/async_tx.c:42:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct dma_chan *
   ^
   static 
   1 error generated.


vim +/__async_tx_find_channel +43 crypto/async_tx/async_tx.c

af1f951eb6ef27 Dan Williams 2009-08-29  35  
9bc89cd82d6f88 Dan Williams 2007-01-02  36  /**
47437b2c9a6431 Dan Williams 2008-02-02  37   * __async_tx_find_channel - find a channel to carry out the operation or let
9bc89cd82d6f88 Dan Williams 2007-01-02  38   *	the transaction execute synchronously
a08abd8ca890a3 Dan Williams 2009-06-03  39   * @submit: transaction dependency and submission modifiers
9bc89cd82d6f88 Dan Williams 2007-01-02  40   * @tx_type: transaction type
9bc89cd82d6f88 Dan Williams 2007-01-02  41   */
9bc89cd82d6f88 Dan Williams 2007-01-02  42  struct dma_chan *
a08abd8ca890a3 Dan Williams 2009-06-03 @43  __async_tx_find_channel(struct async_submit_ctl *submit,
9bc89cd82d6f88 Dan Williams 2007-01-02  44  			enum dma_transaction_type tx_type)
9bc89cd82d6f88 Dan Williams 2007-01-02  45  {
a08abd8ca890a3 Dan Williams 2009-06-03  46  	struct dma_async_tx_descriptor *depend_tx = submit->depend_tx;
a08abd8ca890a3 Dan Williams 2009-06-03  47  
9bc89cd82d6f88 Dan Williams 2007-01-02  48  	/* see if we can keep the chain on one channel */
9bc89cd82d6f88 Dan Williams 2007-01-02  49  	if (depend_tx &&
9bc89cd82d6f88 Dan Williams 2007-01-02  50  	    dma_has_cap(tx_type, depend_tx->chan->device->cap_mask))
9bc89cd82d6f88 Dan Williams 2007-01-02  51  		return depend_tx->chan;
729b5d1b8ec72c Dan Williams 2009-03-25  52  	return async_dma_find_channel(tx_type);
9bc89cd82d6f88 Dan Williams 2007-01-02  53  }
47437b2c9a6431 Dan Williams 2008-02-02  54  EXPORT_SYMBOL_GPL(__async_tx_find_channel);
9bc89cd82d6f88 Dan Williams 2007-01-02  55  #endif
9bc89cd82d6f88 Dan Williams 2007-01-02  56  
19242d7233df7d Dan Williams 2008-04-17  57  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31435 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH
  2021-10-06  9:34 [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH Lukas Bulwahn
  2021-10-06 13:29 ` kernel test robot
  2021-10-06 20:44 ` kernel test robot
@ 2021-10-06 20:51 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-10-06 20:51 UTC (permalink / raw)
  To: Lukas Bulwahn, Dan Williams, Vinod Koul
  Cc: llvm, kbuild-all, kernel-janitors, linux-kernel, Lukas Bulwahn

[-- Attachment #1: Type: text/plain, Size: 3928 bytes --]

Hi Lukas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.15-rc3 next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lukas-Bulwahn/async_tx-correct-reference-to-ASYNC_TX_ENABLE_CHANNEL_SWITCH/20211006-173543
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 02d5e016800d082058b3d3b7c3ede136cdc6ddcb
config: arm-randconfig-r022-20211004 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c0039de2953d15815448b4b3c3bafb45607781e0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/feea9903edb75548c8beb73119676b95ca4f08ef
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lukas-Bulwahn/async_tx-correct-reference-to-ASYNC_TX_ENABLE_CHANNEL_SWITCH/20211006-173543
        git checkout feea9903edb75548c8beb73119676b95ca4f08ef
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> crypto/async_tx/async_tx.c:43:1: warning: no previous prototype for function '__async_tx_find_channel' [-Wmissing-prototypes]
   __async_tx_find_channel(struct async_submit_ctl *submit,
   ^
   crypto/async_tx/async_tx.c:42:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct dma_chan *
   ^
   static 
   1 warning generated.


vim +/__async_tx_find_channel +43 crypto/async_tx/async_tx.c

af1f951eb6ef27 Dan Williams 2009-08-29  35  
9bc89cd82d6f88 Dan Williams 2007-01-02  36  /**
47437b2c9a6431 Dan Williams 2008-02-02  37   * __async_tx_find_channel - find a channel to carry out the operation or let
9bc89cd82d6f88 Dan Williams 2007-01-02  38   *	the transaction execute synchronously
a08abd8ca890a3 Dan Williams 2009-06-03  39   * @submit: transaction dependency and submission modifiers
9bc89cd82d6f88 Dan Williams 2007-01-02  40   * @tx_type: transaction type
9bc89cd82d6f88 Dan Williams 2007-01-02  41   */
9bc89cd82d6f88 Dan Williams 2007-01-02  42  struct dma_chan *
a08abd8ca890a3 Dan Williams 2009-06-03 @43  __async_tx_find_channel(struct async_submit_ctl *submit,
9bc89cd82d6f88 Dan Williams 2007-01-02  44  			enum dma_transaction_type tx_type)
9bc89cd82d6f88 Dan Williams 2007-01-02  45  {
a08abd8ca890a3 Dan Williams 2009-06-03  46  	struct dma_async_tx_descriptor *depend_tx = submit->depend_tx;
a08abd8ca890a3 Dan Williams 2009-06-03  47  
9bc89cd82d6f88 Dan Williams 2007-01-02  48  	/* see if we can keep the chain on one channel */
9bc89cd82d6f88 Dan Williams 2007-01-02  49  	if (depend_tx &&
9bc89cd82d6f88 Dan Williams 2007-01-02  50  	    dma_has_cap(tx_type, depend_tx->chan->device->cap_mask))
9bc89cd82d6f88 Dan Williams 2007-01-02  51  		return depend_tx->chan;
729b5d1b8ec72c Dan Williams 2009-03-25  52  	return async_dma_find_channel(tx_type);
9bc89cd82d6f88 Dan Williams 2007-01-02  53  }
47437b2c9a6431 Dan Williams 2008-02-02  54  EXPORT_SYMBOL_GPL(__async_tx_find_channel);
9bc89cd82d6f88 Dan Williams 2007-01-02  55  #endif
9bc89cd82d6f88 Dan Williams 2007-01-02  56  
19242d7233df7d Dan Williams 2008-04-17  57  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27947 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-10-06 20:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-06  9:34 [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL_SWITCH Lukas Bulwahn
2021-10-06 13:29 ` kernel test robot
2021-10-06 20:44 ` kernel test robot
2021-10-06 20:51 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox