From: Mel Gorman <mgorman@suse.de>
To: Bharata B Rao <bharata@amd.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org
Subject: Re: [RFC PATCH 4/4] sched/numa: Don't update mm->numa_next_scan from fault path
Date: Thu, 7 Oct 2021 11:25:10 +0100 [thread overview]
Message-ID: <20211007102510.GQ3891@suse.de> (raw)
In-Reply-To: <dbb74941-4d6c-3e5a-2f5c-d18001c2856c@amd.com>
On Tue, Oct 05, 2021 at 02:40:15PM +0530, Bharata B Rao wrote:
> >
> > Updating via cmpxchg would be ok to avoid potential collisions between
> > threads updating a shared mm.
>
> Ok, may be I could just resend with changing the scan period update
> to use cmpxchg.
>
> I also notice that in this case of scan period update, we just return
> without resetting the p->numa_faults_locality[]. Do you think if
> skipping the reset doesn't matter in this case?
>
If there is no fault activity or migrations are failing, there is no
advantage to clearing numa_faults_locality[]. The information there
is still useful even if the scan period is updated.
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2021-10-07 10:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 10:57 [PATCH 0/4] A few autonuma cleanups Bharata B Rao
2021-10-04 10:57 ` [PATCH 1/4] sched/numa: Replace hard-coded number by a define in numa_task_group() Bharata B Rao
2021-10-05 8:18 ` Mel Gorman
2021-10-09 10:07 ` [tip: sched/core] " tip-bot2 for Bharata B Rao
2021-10-14 11:16 ` tip-bot2 for Bharata B Rao
2021-10-04 10:57 ` [PATCH 2/4] sched/numa: Remove the redundant member numa_group::fault_cpus Bharata B Rao
2021-10-05 8:21 ` Mel Gorman
2021-10-09 10:07 ` [tip: sched/core] " tip-bot2 for Bharata B Rao
2021-10-14 11:16 ` tip-bot2 for Bharata B Rao
2021-10-04 10:57 ` [PATCH 3/4] sched/numa: Fix a few comments Bharata B Rao
2021-10-05 8:22 ` Mel Gorman
2021-10-09 10:07 ` [tip: sched/core] " tip-bot2 for Bharata B Rao
2021-10-14 11:16 ` tip-bot2 for Bharata B Rao
2021-10-04 10:57 ` [RFC PATCH 4/4] sched/numa: Don't update mm->numa_next_scan from fault path Bharata B Rao
2021-10-05 8:23 ` Mel Gorman
2021-10-05 9:10 ` Bharata B Rao
2021-10-07 10:25 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007102510.GQ3891@suse.de \
--to=mgorman@suse.de \
--cc=bharata@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox