From: Dan Carpenter <dan.carpenter@oracle.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: Colin King <colin.king@canonical.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steve French <sfrench@samba.org>,
Hyunchul Lee <hyc.lee@gmail.com>,
Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] cifsd: Fix a less than zero comparison with the unsigned int nbytes
Date: Thu, 7 Oct 2021 16:35:41 +0300 [thread overview]
Message-ID: <20211007133541.GC2048@kadam> (raw)
In-Reply-To: <CAKYAXd_aOawm4MkBtkTxnLfeEk+F5VgrJHjyH8GSaeHjQbLtGQ@mail.gmail.com>
On Thu, Oct 07, 2021 at 09:37:04PM +0900, Namjae Jeon wrote:
> 2021-10-07 20:47 GMT+09:00, Colin King <colin.king@canonical.com>:
> >
> > Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
> I think that this alarm is caused by b66732021c64 (ksmbd: add
> validation in smb2_ioctl).
> Fixes tag may be not needed. Because b66732021c64 patch is not applied
> to Linus' tree yet ?
If you are going to modify the commit to include this fix then that's
fine. Otherise if you are going to apply this commit then the Fixes
tag is still required.
The fixes tag saves time for backporters because they can automatically
rule out that this patch needs to be backported. Or if they backport
commit b66732021c64 then they know they have to backport the fix as
well.
Also the Fixes tag is used for other purposes besides backporting.
It helps review. It's also an interesting metric to measure how long
between the bug is introduced and the fix is applied.
regards,
dan carpenter
next prev parent reply other threads:[~2021-10-07 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 11:47 [PATCH][next] cifsd: Fix a less than zero comparison with the unsigned int nbytes Colin King
2021-10-07 12:37 ` Namjae Jeon
2021-10-07 12:51 ` Namjae Jeon
2021-10-07 13:35 ` Dan Carpenter [this message]
2021-10-07 14:31 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007133541.GC2048@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=hyc.lee@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox