From: Anders Roxell <anders.roxell@linaro.org>
To: catalin.marinas@arm.com, will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Anders Roxell <anders.roxell@linaro.org>
Subject: [PATCH] arm64: asm: vdso: gettimeofday: export common variables
Date: Thu, 7 Oct 2021 21:57:54 +0200 [thread overview]
Message-ID: <20211007195754.678124-1-anders.roxell@linaro.org> (raw)
When building the kernel with sparse enabled 'C=1' the following
warnings can be seen:
arch/arm64/kernel/vdso/vgettimeofday.c:9:5: warning: symbol '__kernel_clock_gettime' was not declared. Should it be static?
arch/arm64/kernel/vdso/vgettimeofday.c:15:5: warning: symbol '__kernel_gettimeofday' was not declared. Should it be static?
arch/arm64/kernel/vdso/vgettimeofday.c:21:5: warning: symbol '__kernel_clock_getres' was not declared. Should it be static?
Rework so the variables are exported, since these variables are
created and used in vdso/vgettimeofday.c, also used in vdso.lds.S.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
arch/arm64/include/asm/vdso/gettimeofday.h | 7 +++++++
arch/arm64/kernel/vdso/vgettimeofday.c | 1 +
2 files changed, 8 insertions(+)
diff --git a/arch/arm64/include/asm/vdso/gettimeofday.h b/arch/arm64/include/asm/vdso/gettimeofday.h
index 4f7a629df81f..da8dfb119c30 100644
--- a/arch/arm64/include/asm/vdso/gettimeofday.h
+++ b/arch/arm64/include/asm/vdso/gettimeofday.h
@@ -12,6 +12,13 @@
#define VDSO_HAS_CLOCK_GETRES 1
+extern int __kernel_clock_gettime(clockid_t clock,
+ struct __kernel_timespec *ts);
+extern int __kernel_gettimeofday(struct __kernel_old_timeval *tv,
+ struct timezone *tz);
+extern int __kernel_clock_getres(clockid_t clock_id,
+ struct __kernel_timespec *res);
+
static __always_inline
int gettimeofday_fallback(struct __kernel_old_timeval *_tv,
struct timezone *_tz)
diff --git a/arch/arm64/kernel/vdso/vgettimeofday.c b/arch/arm64/kernel/vdso/vgettimeofday.c
index 4236cf34d7d9..1a44d1e32746 100644
--- a/arch/arm64/kernel/vdso/vgettimeofday.c
+++ b/arch/arm64/kernel/vdso/vgettimeofday.c
@@ -5,6 +5,7 @@
* Copyright (C) 2018 ARM Limited
*
*/
+#include <asm/vdso/gettimeofday.h>
int __kernel_clock_gettime(clockid_t clock,
struct __kernel_timespec *ts)
--
2.33.0
next reply other threads:[~2021-10-07 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 19:57 Anders Roxell [this message]
2021-10-11 10:02 ` [PATCH] arm64: asm: vdso: gettimeofday: export common variables Will Deacon
2021-10-11 12:47 ` Arnd Bergmann
2021-10-11 13:33 ` Catalin Marinas
2023-01-09 7:48 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007195754.678124-1-anders.roxell@linaro.org \
--to=anders.roxell@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox