From: Bjorn Helgaas <helgaas@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Werner Sembach <wse@tuxedocomputers.com>,
benoitg@coeus.ca, bhelgaas@google.com, hpa@zytor.com,
juhapekka.heikkila@gmail.com, linux-kernel@vger.kernel.org,
mingo@redhat.com, tglx@linutronix.de, x86@kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH RESEND] x86/resource: Do not exclude regions that are marked as MMIO in EFI memmap
Date: Fri, 8 Oct 2021 05:56:38 -0500 [thread overview]
Message-ID: <20211008105638.GA1313587@bhelgaas> (raw)
In-Reply-To: <YWATQgGOFQIlLOlV@zn.tnic>
[+cc linux-pci]
On Fri, Oct 08, 2021 at 11:45:38AM +0200, Borislav Petkov wrote:
> On Fri, Oct 08, 2021 at 12:23:31PM +0300, Mika Westerberg wrote:
> > Hi,
> >
> > On Fri, Oct 08, 2021 at 10:55:49AM +0200, Werner Sembach wrote:
> > > Is there any update on this matter? Also happens on discrete Thunderbolt 4 chips:
> > > https://bugzilla.kernel.org/show_bug.cgi?id=214259
> >
> > AFAICT no updates.
> >
> > @Bjorn, x86 maintainers,
> >
> > If there are no alternatives can we get this patch merged so that people
> > don't need to carry out-of-tree patches to get their systems working?
>
> Just my 2¢ from briefly skimming over this:
>
> So this reads yet again as BIOS is to blame but what else is new?
>
> "All in all, I think we can fix this by modifying
> arch_remove_reservations() to check the EFI type as well and if it is
> EFI_MEMORY_MAPPED_IO skip the clipping in that case."
>
> And this like we should trust EFI to mark those regions properly, which
> is more of the same but in different color.
>
> That original commit talks about windoze doing a different allocation
> scheme and thus not trusting the untrustworthy firmware anyway and that
> sounds like something we should do too. But WTH do I know?!
There are a couple other threads reporting similar issues:
https://lore.kernel.org/r/20210624095324.34906-1-hui.wang@canonical.com
https://lore.kernel.org/r/20211005150956.303707-1-hdegoede@redhat.com
I think 4dc2287c1805 ("x86: avoid E820 regions when allocating address
space") was a mistake and we should remove that instead of adding more
complexity to it.
But that requires another approach to fix the issue that 4dc2287c1805
addressed.
Bjorn
next prev parent reply other threads:[~2021-10-08 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 16:47 [PATCH RESEND] x86/resource: Do not exclude regions that are marked as MMIO in EFI memmap Mika Westerberg
2021-10-08 8:55 ` Werner Sembach
2021-10-08 9:23 ` Mika Westerberg
2021-10-08 9:45 ` Borislav Petkov
2021-10-08 10:56 ` Bjorn Helgaas [this message]
2021-10-08 15:44 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008105638.GA1313587@bhelgaas \
--to=helgaas@kernel.org \
--cc=benoitg@coeus.ca \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=juhapekka.heikkila@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=wse@tuxedocomputers.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox