From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A706C433F5 for ; Fri, 8 Oct 2021 11:31:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 448E160F51 for ; Fri, 8 Oct 2021 11:31:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240760AbhJHLd2 (ORCPT ); Fri, 8 Oct 2021 07:33:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:59314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240764AbhJHLcF (ORCPT ); Fri, 8 Oct 2021 07:32:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CD5F461040; Fri, 8 Oct 2021 11:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633692580; bh=vItgBdU7Zpij+YFPmETvQ4GYWk6GNPFn4Vv0M4mh/zk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q7681ysmjOPaH2HSFoX5WNPY1Q0ioF17DPV1+XiS34sx0mTKMsfH53tMVYYFApqfR LALutJjqKa1KI3AyX10yVkZPyKU7ncMBNLcjnNPLf//zIx/d5GjNBpWbfYeGW7HsUe lR6ybRp9y78IlxcOldMhNavbitI9zZPWqeyN4mzg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Changbin Du , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.19 10/12] tools/vm/page-types: remove dependency on opt_file for idle page tracking Date: Fri, 8 Oct 2021 13:27:58 +0200 Message-Id: <20211008112714.924979518@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211008112714.601107695@linuxfoundation.org> References: <20211008112714.601107695@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Changbin Du [ Upstream commit ebaeab2fe87987cef28eb5ab174c42cd28594387 ] Idle page tracking can also be used for process address space, not only file mappings. Without this change, using with '-i' option for process address space encounters below errors reported. $ sudo ./page-types -p $(pidof bash) -i mark page idle: Bad file descriptor mark page idle: Bad file descriptor mark page idle: Bad file descriptor mark page idle: Bad file descriptor ... Link: https://lkml.kernel.org/r/20210917032826.10669-1-changbin.du@gmail.com Signed-off-by: Changbin Du Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- tools/vm/page-types.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c index 1ff3a6c0367b..89063b967b6b 100644 --- a/tools/vm/page-types.c +++ b/tools/vm/page-types.c @@ -1341,7 +1341,7 @@ int main(int argc, char *argv[]) if (opt_list && opt_list_mapcnt) kpagecount_fd = checked_open(PROC_KPAGECOUNT, O_RDONLY); - if (opt_mark_idle && opt_file) + if (opt_mark_idle) page_idle_fd = checked_open(SYS_KERNEL_MM_PAGE_IDLE, O_RDWR); if (opt_list && opt_pid) -- 2.33.0