From: Guenter Roeck <linux@roeck-us.net>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] hwmon: (pmbus/lm25066) Add offset coefficients
Date: Fri, 8 Oct 2021 06:37:22 -0700 [thread overview]
Message-ID: <20211008133722.GA894797@roeck-us.net> (raw)
In-Reply-To: <20210928092242.30036-2-zev@bewilderbeest.net>
On Tue, Sep 28, 2021 at 02:22:35AM -0700, Zev Weiss wrote:
> With the exception of the lm5066i, all the devices handled by this
> driver had been missing their offset ('b') coefficients for direct
> format readings.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/pmbus/lm25066.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/drivers/hwmon/pmbus/lm25066.c b/drivers/hwmon/pmbus/lm25066.c
> index d209e0afc2ca..1a660c4cd19f 100644
> --- a/drivers/hwmon/pmbus/lm25066.c
> +++ b/drivers/hwmon/pmbus/lm25066.c
> @@ -55,22 +55,27 @@ static struct __coeff lm25066_coeff[6][PSC_NUM_CLASSES + 2] = {
> [lm25056] = {
> [PSC_VOLTAGE_IN] = {
> .m = 16296,
> + .b = 1343,
> .R = -2,
> },
> [PSC_CURRENT_IN] = {
> .m = 13797,
> + .b = -1833,
> .R = -2,
> },
> [PSC_CURRENT_IN_L] = {
> .m = 6726,
> + .b = -537,
> .R = -2,
> },
> [PSC_POWER] = {
> .m = 5501,
> + .b = -2908,
> .R = -3,
> },
> [PSC_POWER_L] = {
> .m = 26882,
> + .b = -5646,
> .R = -4,
> },
> [PSC_TEMPERATURE] = {
> @@ -82,26 +87,32 @@ static struct __coeff lm25066_coeff[6][PSC_NUM_CLASSES + 2] = {
> [lm25066] = {
> [PSC_VOLTAGE_IN] = {
> .m = 22070,
> + .b = -1800,
> .R = -2,
> },
> [PSC_VOLTAGE_OUT] = {
> .m = 22070,
> + .b = -1800,
> .R = -2,
> },
> [PSC_CURRENT_IN] = {
> .m = 13661,
> + .b = -5200,
> .R = -2,
> },
> [PSC_CURRENT_IN_L] = {
> .m = 6852,
> + .b = -3100,
> .R = -2,
> },
> [PSC_POWER] = {
> .m = 736,
> + .b = -3300,
> .R = -2,
> },
> [PSC_POWER_L] = {
> .m = 369,
> + .b = -1900,
> .R = -2,
> },
> [PSC_TEMPERATURE] = {
> @@ -111,26 +122,32 @@ static struct __coeff lm25066_coeff[6][PSC_NUM_CLASSES + 2] = {
> [lm5064] = {
> [PSC_VOLTAGE_IN] = {
> .m = 4611,
> + .b = -642,
> .R = -2,
> },
> [PSC_VOLTAGE_OUT] = {
> .m = 4621,
> + .b = 423,
> .R = -2,
> },
> [PSC_CURRENT_IN] = {
> .m = 10742,
> + .b = 1552,
> .R = -2,
> },
> [PSC_CURRENT_IN_L] = {
> .m = 5456,
> + .b = 2118,
> .R = -2,
> },
> [PSC_POWER] = {
> .m = 1204,
> + .b = 8524,
> .R = -3,
> },
> [PSC_POWER_L] = {
> .m = 612,
> + .b = 11202,
> .R = -3,
> },
> [PSC_TEMPERATURE] = {
> @@ -140,26 +157,32 @@ static struct __coeff lm25066_coeff[6][PSC_NUM_CLASSES + 2] = {
> [lm5066] = {
> [PSC_VOLTAGE_IN] = {
> .m = 4587,
> + .b = -1200,
> .R = -2,
> },
> [PSC_VOLTAGE_OUT] = {
> .m = 4587,
> + .b = -2400,
> .R = -2,
> },
> [PSC_CURRENT_IN] = {
> .m = 10753,
> + .b = -1200,
> .R = -2,
> },
> [PSC_CURRENT_IN_L] = {
> .m = 5405,
> + .b = -600,
> .R = -2,
> },
> [PSC_POWER] = {
> .m = 1204,
> + .b = -6000,
> .R = -3,
> },
> [PSC_POWER_L] = {
> .m = 605,
> + .b = -8000,
> .R = -3,
> },
> [PSC_TEMPERATURE] = {
next prev parent reply other threads:[~2021-10-08 13:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 9:22 [PATCH 0/8] hwmon: (pmbus/lm25066) Configurable sense resistor, other cleanups Zev Weiss
2021-09-28 9:22 ` [PATCH 1/8] hwmon: (pmbus/lm25066) Add offset coefficients Zev Weiss
2021-10-08 13:37 ` Guenter Roeck [this message]
2021-09-28 9:22 ` [PATCH 2/8] hwmon: (pmbus/lm25066) Adjust lm25066 PSC_CURRENT_IN_L mantissa Zev Weiss
2021-10-08 13:46 ` Guenter Roeck
2021-09-28 9:22 ` [PATCH 3/8] hwmon: (pmbus/lm25066) Avoid forward declaration of lm25066_id Zev Weiss
2021-10-08 13:47 ` Guenter Roeck
2021-09-28 9:22 ` [PATCH 4/8] hwmon: (pmbus/lm25066) Let compiler determine outer dimension of lm25066_coeff Zev Weiss
2021-10-08 13:47 ` Guenter Roeck
2021-09-28 9:22 ` [PATCH 5/8] hwmon: (pmbus/lm25066) Mark lm25066_coeff array const Zev Weiss
2021-10-08 13:49 ` Guenter Roeck
2021-09-28 9:22 ` [PATCH 6/8] hwmon: (pmbus/lm25066) Add OF device ID table Zev Weiss
2021-10-08 13:52 ` Guenter Roeck
2021-10-08 13:59 ` Guenter Roeck
2021-09-28 9:22 ` [PATCH 7/8] hwmon: (pmbus/lm25066) Support configurable sense resistor values Zev Weiss
2021-10-08 14:03 ` Guenter Roeck
2021-09-28 9:22 ` [PATCH 8/8] dt-bindings: hwmon/pmbus: Add ti,lm25066 power-management IC Zev Weiss
2021-10-04 18:28 ` Rob Herring
2021-10-08 14:05 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008133722.GA894797@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox