From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77663C433F5 for ; Sat, 9 Oct 2021 18:07:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57CD860F23 for ; Sat, 9 Oct 2021 18:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229846AbhJISJM (ORCPT ); Sat, 9 Oct 2021 14:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbhJISJL (ORCPT ); Sat, 9 Oct 2021 14:09:11 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E8B8C061570 for ; Sat, 9 Oct 2021 11:07:14 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1633802832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=K6elq7AFobxNdKY5PG3UHJIIIjiAppGcE9M8qcToufc=; b=sTPGTwNAQTzHug+UFuxVG80POuk9/PMiMNa/I12ODj5K5w6CN+KSbwrfiHoGED/6kM9Av0 783mzEBbyQD734w3KpPFEiVlfpB0Op/AkSS1Plsun4+T+yUvP/eK4ACeGTLIfjL4k0udiR L5dWgtEZDodMKnLfi5jkDXpt2z59QkM= From: Tao Zhou To: linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira Cc: Tao Zhou Subject: [PATCH] sched/pelt: Use or not add in update_irq_load_avg() Date: Sun, 10 Oct 2021 02:06:42 +0800 Message-Id: <20211009180642.20319-1-tao.zhou@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: tao.zhou@linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ret value of update_irq_load_avg() can be 2. And this value is used in __update_blocked_others(). It should be 0 or 1. Use OR operation in update_irq_load_avg(). --- kernel/sched/pelt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/pelt.c b/kernel/sched/pelt.c index a554e3bbab2b..7edf21f7977c 100644 --- a/kernel/sched/pelt.c +++ b/kernel/sched/pelt.c @@ -458,7 +458,7 @@ int update_irq_load_avg(struct rq *rq, u64 running) 0, 0, 0); - ret += ___update_load_sum(rq->clock, &rq->avg_irq, + ret |= ___update_load_sum(rq->clock, &rq->avg_irq, 1, 1, 1); -- 2.32.0