From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B390C433FE for ; Sat, 9 Oct 2021 22:41:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C13760F6B for ; Sat, 9 Oct 2021 22:41:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231354AbhJIWnv (ORCPT ); Sat, 9 Oct 2021 18:43:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbhJIWnt (ORCPT ); Sat, 9 Oct 2021 18:43:49 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1D8AC061570; Sat, 9 Oct 2021 15:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=irb6FRwPU2dQSsNxYUCgkPV+9G3ES5Ac2nbK8COEBzU=; b=DXMGHD/JX7AFdlaWO/D2GkVpwP QHCWfAPEgda5tzNYUSnnKZKCGkQknXnodDJbMYotyD8jaVhs69KREgh7jIBPVJ/5E16H/9bcgXTKD IroinWzWCbs73n5/onzduuOpL3gxMExtapMVaQDRRpCm+DFsvm9c3Pm+SfhOnfW5wzJefTXiU1YGc VgkiiMjqM65eIxzikDCe9D2I1XruRKUFEougWAdwFo2xqTsuoZ/gbloLdtivYIomIPmuJTli09DRS c3QhGj6d23zWxNrWup/YMnbaDJBwo5HH6sd5/tN9kVP1mZSgoEURfTGx2vX/FVt2MFL7+d9egwyvg cVv9mw4Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZL2B-008uuN-8R; Sat, 09 Oct 2021 22:41:39 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id D30FD9811D4; Sun, 10 Oct 2021 00:41:38 +0200 (CEST) Date: Sun, 10 Oct 2021 00:41:38 +0200 From: Peter Zijlstra To: "Pratik R. Sampat" Cc: bristot@redhat.com, christian@brauner.io, ebiederm@xmission.com, lizefan.x@bytedance.com, tj@kernel.org, hannes@cmpxchg.org, mingo@kernel.org, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, containers@lists.linux.dev, containers@lists.linux-foundation.org, pratik.r.sampat@gmail.com Subject: Re: [RFC 0/5] kernel: Introduce CPU Namespace Message-ID: <20211009224138.GZ174703@worktop.programming.kicks-ass.net> References: <20211009151243.8825-1-psampat@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211009151243.8825-1-psampat@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 09, 2021 at 08:42:38PM +0530, Pratik R. Sampat wrote: > Current shortcomings in the prototype: > -------------------------------------- > 1. Containers also frequently use cfs period and quotas to restrict CPU > runtime also known as millicores in modern container runtimes. > The RFC interface currently does not account for this in > the scheme of things. > 2. While /proc/stat is now namespace aware and userspace programs like > top will see the CPU utilization for their view of virtual CPUs; > if the system or any other application outside the namespace > bumps up the CPU utilization it will still show up in sys/user time. > This should ideally be shown as stolen time instead. > The current implementation plugs into the display of stats rather > than accounting which causes incorrect reporting of stolen time. > 3. The current implementation assumes that no hotplug operations occur > within a container and hence the online and present cpus within a CPU > namespace are always the same and query the same CPU namespace mask > 4. As this is a proof of concept, currently we do not differentiate > between cgroup cpus_allowed and effective_cpus and plugs them into > the same virtual CPU map of the namespace > 5. As described in a fair use implication earlier, knowledge of the > CPU topology can potentially be taken an misused with a flood. > While scrambling the CPUset in the namespace can help by > obfuscation of information, the topology can still be roughly figured > out with the use of IPI latencies to determine siblings or far away > cores 6. completely destroys and ignores any machine topology information.