Re: [PATCH v7 1/2] dt-bindings: hwmon: Add nct7802 bindings

Oskar Senft
2021-10-20T16:49:58Z

Hi Rob

Thanks for the review comments!

> > +patternProperties:
> > + "^channel@[0-3]$":
> > + type: object
>
> I would move the 'additionalProperties' here. I think that's a bit
> easier to read.

Following the same thought, I also moved the 'additionalProperties' on
the top level up to above its 'properties'.

> blank line

Thanks, I added the missing blank lines. I'm not sure what I was thinking.

> > + channel@0 { /* LTD */
> > + reg = <0>;
> > + status = "okay";
>
> Don't show status in examples.

Oh yes, you mentioned that before, I'm sorry. They're removed now.

I sent a PATCH v8 with the changes.

Oskar.