Re: [net-next PATCH v5 04/14] dt-bindings: net: dsa: qca8k: Document support for CPU port 6

Ansuel Smith
2021-10-11T02:03:21Z

On Sun, Oct 10, 2021 at 06:50:39PM -0700, Florian Fainelli wrote:
>
>
> On 10/10/2021 6:30 PM, Ansuel Smith wrote:
> > The switch now support CPU port to be set 6 instead of be hardcoded to
> > 0. Document support for it and describe logic selection.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > index cc214e655442..aeb206556f54 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt
> > @@ -29,7 +29,11 @@ the mdio MASTER is used as communication.
> > Don't use mixed external and internal mdio-bus configurations, as this is
> > not supported by the hardware.
> > -The CPU port of this switch is always port 0.
> > +This switch support 2 CPU port.
>
> Plural: ports.
>
> > Normally and advised configuration is with
> > +CPU port set to port 0. It is also possible to set the CPU port to port 6
> > +if the device requires it. The driver will configure the switch to the defined
> > +port. With both CPU port declared the first CPU port is selected as primary
> > +and the secondary CPU ignored.
>
> Is this universally supported by all models that this binding covers? If
> not, you might want to explain that?
> --
> Florian

Yes we tested this and both qca8327 and qca8337 work correctly with cpu
port6 set as primary port. (no cpu0 defined)
If you were referring to double cpu mode. That is the common
configuration with this switch but we currently doesn't support
multi-cpu in DSA.

--
Ansuel