From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE79DC433F5 for ; Mon, 11 Oct 2021 07:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1BCC6056B for ; Mon, 11 Oct 2021 07:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234490AbhJKHh7 (ORCPT ); Mon, 11 Oct 2021 03:37:59 -0400 Received: from verein.lst.de ([213.95.11.211]:36161 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231974AbhJKHh6 (ORCPT ); Mon, 11 Oct 2021 03:37:58 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C8AF568AFE; Mon, 11 Oct 2021 09:35:56 +0200 (CEST) Date: Mon, 11 Oct 2021 09:35:56 +0200 From: Christoph Hellwig To: "Yan, Zheng" Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, hch@lst.de, paskripkin@gmail.com, "Yan, Zheng" Subject: Re: [PATCH v2] block: nbd: fix sanity check for first_minor Message-ID: <20211011073556.GA10735@lst.de> References: <20211011024509.2012-1-ukernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211011024509.2012-1-ukernel@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 11, 2021 at 10:45:09AM +0800, Yan, Zheng wrote: > From: "Yan, Zheng" > > Device's minor is a 20-bits number, max value is 0xfffff. I'd just drop this check again now that we do have proper error handling in add_disk.