Re: [PATCH v2 1/3] memory-hotplug.rst: fix two instances of "movablecore" that should be "movable_node"

Mike Rapoport
2021-10-11T09:27:28Z

On Mon, Oct 11, 2021 at 10:20:56AM +0200, David Hildenbrand wrote:
> We really want to refer to the "movable_node" kernel command line
> parameter here.
>
> Fixes: ac3332c44767 ("memory-hotplug.rst: complete admin-guide overhaul")
> Signed-off-by: David Hildenbrand <david@redhat.com>

Acked-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
> Documentation/admin-guide/mm/memory-hotplug.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst
> index 03dfbc925252..27d748cb6ee0 100644
> --- a/Documentation/admin-guide/mm/memory-hotplug.rst
> +++ b/Documentation/admin-guide/mm/memory-hotplug.rst
> @@ -166,7 +166,7 @@ Or alternatively::
> % echo 1 > /sys/devices/system/memory/memoryXXX/online
>
> The kernel will select the target zone automatically, usually defaulting to
> -``ZONE_NORMAL`` unless ``movablecore=1`` has been specified on the kernel
> +``ZONE_NORMAL`` unless ``movable_node`` has been specified on the kernel
> command line or if the memory block would intersect the ZONE_MOVABLE already.
>
> One can explicitly request to associate an offline memory block with
> @@ -393,7 +393,7 @@ command line parameters are relevant:
> ======================== =======================================================
> ``memhp_default_state`` configure auto-onlining by essentially setting
> ``/sys/devices/system/memory/auto_online_blocks``.
> -``movablecore`` configure automatic zone selection of the kernel. When
> +``movable_node`` configure automatic zone selection in the kernel. When
> set, the kernel will default to ZONE_MOVABLE, unless
> other zones can be kept contiguous.
> ======================== =======================================================
> --
> 2.31.1
>

--
Sincerely yours,
Mike.