From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C88C4332F for ; Mon, 11 Oct 2021 23:28:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8949F60F0F for ; Mon, 11 Oct 2021 23:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235714AbhJKXap (ORCPT ); Mon, 11 Oct 2021 19:30:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235583AbhJKXam (ORCPT ); Mon, 11 Oct 2021 19:30:42 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 249B8C06161C for ; Mon, 11 Oct 2021 16:28:42 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id az39so4240203qkb.5 for ; Mon, 11 Oct 2021 16:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hKTDl4kdaWB0vdYudkwpZowlFD1zaZpzSpL3qYnGjpI=; b=HgSVsa1leI1AlSIfToVWroe+BjAOI3ghwR21CHGPDVexnWIRNvq+Q6E9d3FU+ST+no ocS0/TW3SNZ8jyMLrwCJrPh0ePUJ+a688MNeO/SOH6dsbggdYjQGAUsJxiPe5U0kF/4c XY58+grwbQEppK31zpbsIZaW6qYJZ2vewp8ofGFLbXaclZQIMcZ93nEBHioo26AFAdN3 o9ugEBJiQo11Zaj9DuRnUJDPPLYMfgS8KowTy+yVz6++iq5k4ln0p/MdXC+vaaQP/YGk 4LaDhUUPgzqijbwXAaNpf83nIDlspt7EVCcaadtiRVk58NDA1pLNB31/ejPvhAokpOj1 4Y3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hKTDl4kdaWB0vdYudkwpZowlFD1zaZpzSpL3qYnGjpI=; b=YkOyOJxlFMpX7dMZOSiQJx8By5Wkzgm1r21mfraaqas2syywbIWvUCvw5SSn9vp0Bc mtw6ZKIiA59YammIWBKxKCQ+XefiG7gy6eQ5QdZhg7qMvN0284bIXvS109JF7/SP3uQ3 FdbihNRdXXKEU93OSIgnM8IOS6o6Swq7IP+xMdnijf2hnwIm/QCefFXb37SQSg33Tr/x vHAAYFrfyDw2U6l63LR8fbwgNwnCzSVTKqe4MTjcF4D8O97r+YGtjl4TbLqDV2swobd+ ufXy677DmeIZSoqxnFy0OSiFiFK9NkorhKjRBO5HpihbpBxWB01/yZfQkHTHWAx8w3CP jgNg== X-Gm-Message-State: AOAM532MOjk8nMJNCwgufmcWVWVSoa/QMVVyeZxQoHTrFw5qTOMJvqCq MZYIpw8C4VMYHbcpmXOuRY9U3g== X-Google-Smtp-Source: ABdhPJztEyniOAoNC1NU3iq7Ij0MXitTU2tCF7xYZyS71yMXt88Vb38CmA4delGadNYZaeqqHQ8bqQ== X-Received: by 2002:a37:f71a:: with SMTP id q26mr16843729qkj.3.1633994921355; Mon, 11 Oct 2021 16:28:41 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id d5sm5245821qtr.61.2021.10.11.16.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 16:28:40 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1ma4il-00Dk4y-VJ; Mon, 11 Oct 2021 20:28:39 -0300 Date: Mon, 11 Oct 2021 20:28:39 -0300 From: Jason Gunthorpe To: Gal Pressman Cc: Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Doug Ledford , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Oded Gabbay , Tomer Tayar , Yossi Leybovich , Alexander Matushevsky , Leon Romanovsky , Jianxin Xiong , Firas Jahjah Subject: Re: [RFC PATCH 2/2] RDMA/efa: Add support for dmabuf memory regions Message-ID: <20211011232839.GF2688930@ziepe.ca> References: <20211007104301.76693-1-galpress@amazon.com> <20211007104301.76693-3-galpress@amazon.com> <20211007114018.GD2688930@ziepe.ca> <77082c57-29f8-1eba-b260-7cb658ec34d1@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77082c57-29f8-1eba-b260-7cb658ec34d1@amazon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 10, 2021 at 09:55:49AM +0300, Gal Pressman wrote: > On 07/10/2021 14:40, Jason Gunthorpe wrote: > > On Thu, Oct 07, 2021 at 01:43:00PM +0300, Gal Pressman wrote: > > > >> @@ -1491,26 +1493,29 @@ static int efa_create_pbl(struct efa_dev *dev, > >> return 0; > >> } > >> > >> -struct ib_mr *efa_reg_mr(struct ib_pd *ibpd, u64 start, u64 length, > >> - u64 virt_addr, int access_flags, > >> - struct ib_udata *udata) > >> +static void efa_dmabuf_invalidate_cb(struct dma_buf_attachment *attach) > >> +{ > >> + WARN_ON_ONCE(1, > >> + "Invalidate callback should not be called when memory is pinned\n"); > >> +} > >> + > >> +static struct dma_buf_attach_ops efa_dmabuf_attach_ops = { > >> + .allow_peer2peer = true, > >> + .move_notify = efa_dmabuf_invalidate_cb, > >> +}; > > > > Shouldn't move_notify really just be left as NULL? I mean fixing > > whatever is preventing that? > > That's what I had in the previous RFC and I think Christian didn't really like it. Well, having drivers define a dummy function that only fails looks a lot worse to me. If not null then it should be a general 'dmabuf_unsupported_move_notify' shared function > >> + err = ib_umem_dmabuf_map_pages(umem_dmabuf); > >> + if (err) { > >> + ibdev_dbg(&dev->ibdev, "Failed to map dmabuf pages\n"); > >> + goto err_unpin; > >> + } > >> + dma_resv_unlock(umem_dmabuf->attach->dmabuf->resv); > > > > If it is really this simple the core code should have this logic, > > 'ib_umem_dmabuf_get_pinned()' or something > > Should get_pinned do just get + dma_buf_pin, or should it do > ib_umem_dmabuf_map_pages as well? Yes the map_pages too, a umem is supposed to be dma mapped after creation. Jason