* drivers/net/ethernet/smsc/smc911x.c:1674 smc911x_ethtool_seteeprom() warn: inconsistent indenting
@ 2021-10-11 17:05 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-10-11 17:05 UTC (permalink / raw)
To: Andrew Lunn; +Cc: kbuild-all, linux-kernel, Jakub Kicinski
[-- Attachment #1: Type: text/plain, Size: 3826 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc
commit: 7958ba7e6273a02f49432a2506958d0f59b5b8da drivers: net: smsc: Add COMPILE_TEST support
date: 11 months ago
config: riscv-randconfig-m031-20211010 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/net/ethernet/smsc/smc911x.c:1674 smc911x_ethtool_seteeprom() warn: inconsistent indenting
drivers/net/ethernet/smsc/smc91x.c:2128 smc_request_attrib() warn: should '(64 * 1024) << (lp->io_shift)' be a 64 bit type?
drivers/net/ethernet/smsc/smc91x.c:2141 smc_release_attrib() warn: should '(64 * 1024) << (lp->io_shift)' be a 64 bit type?
drivers/net/ethernet/smsc/smc91x.c:2344 smc_drv_probe() warn: should '16 << (lp->io_shift)' be a 64 bit type?
drivers/net/ethernet/smsc/smc91x.c:2434 smc_drv_remove() warn: should '16 << (lp->io_shift)' be a 64 bit type?
Old smatch warnings:
drivers/net/ethernet/smsc/smc91x.c:2403 smc_drv_probe() warn: should '16 << (lp->io_shift)' be a 64 bit type?
vim +1674 drivers/net/ethernet/smsc/smc911x.c
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1655
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1656 static int smc911x_ethtool_seteeprom(struct net_device *dev,
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1657 struct ethtool_eeprom *eeprom, u8 *data)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1658 {
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1659 int i, ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1660
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1661 /* Enable erase */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1662 if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_EWEN_, 0 ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1663 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1664 for(i=eeprom->offset;i<(eeprom->offset+eeprom->len);i++) {
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1665 /* erase byte */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1666 if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_ERASE_, i ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1667 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1668 /* write byte */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1669 if ((ret=smc911x_ethtool_write_eeprom_byte(dev, *data))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1670 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1671 if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_WRITE_, i ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1672 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1673 }
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 @1674 return 0;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1675 }
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1676
:::::: The code at line 1674 was first introduced by commit
:::::: 0a0c72c9118c4e63080eb409f0cfdf15808d23a4 [PATCH] RE: [PATCH 1/1] net driver: Add support for SMSC LAN911x line of ethernet chips
:::::: TO: Dustin McIntire <dustin@sensoria.com>
:::::: CC: Jeff Garzik <jeff@garzik.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35150 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/net/ethernet/smsc/smc911x.c:1674 smc911x_ethtool_seteeprom() warn: inconsistent indenting
@ 2022-01-30 17:02 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-01-30 17:02 UTC (permalink / raw)
To: Andrew Lunn; +Cc: kbuild-all, linux-kernel, Jakub Kicinski
Hi Andrew,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 24f4db1f3a2725a6308105081d822b26889e1018
commit: 7958ba7e6273a02f49432a2506958d0f59b5b8da drivers: net: smsc: Add COMPILE_TEST support
date: 1 year, 3 months ago
config: powerpc-randconfig-m031-20220130 (https://download.01.org/0day-ci/archive/20220131/202201310032.hJJ6daS7-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
drivers/net/ethernet/smsc/smc911x.c:1674 smc911x_ethtool_seteeprom() warn: inconsistent indenting
vim +1674 drivers/net/ethernet/smsc/smc911x.c
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1655
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1656 static int smc911x_ethtool_seteeprom(struct net_device *dev,
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1657 struct ethtool_eeprom *eeprom, u8 *data)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1658 {
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1659 int i, ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1660
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1661 /* Enable erase */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1662 if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_EWEN_, 0 ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1663 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1664 for(i=eeprom->offset;i<(eeprom->offset+eeprom->len);i++) {
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1665 /* erase byte */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1666 if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_ERASE_, i ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1667 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1668 /* write byte */
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1669 if ((ret=smc911x_ethtool_write_eeprom_byte(dev, *data))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1670 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1671 if ((ret=smc911x_ethtool_write_eeprom_cmd(dev, E2P_CMD_EPC_CMD_WRITE_, i ))!=0)
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1672 return ret;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1673 }
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 @1674 return 0;
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1675 }
0a0c72c9118c4e drivers/net/smc911x.c Dustin McIntire 2006-04-19 1676
:::::: The code at line 1674 was first introduced by commit
:::::: 0a0c72c9118c4e63080eb409f0cfdf15808d23a4 [PATCH] RE: [PATCH 1/1] net driver: Add support for SMSC LAN911x line of ethernet chips
:::::: TO: Dustin McIntire <dustin@sensoria.com>
:::::: CC: Jeff Garzik <jeff@garzik.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-30 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-11 17:05 drivers/net/ethernet/smsc/smc911x.c:1674 smc911x_ethtool_seteeprom() warn: inconsistent indenting kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-01-30 17:02 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox