public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: davidcomponentone@gmail.com
To: Viktor.Rosendahl@bmw.de
Cc: rostedt@goodmis.org, colin.king@canonical.com,
	davidcomponentone@gmail.com, vulab@iscas.ac.cn,
	linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
Subject: [PATCH] Fix application of sizeof to pointer
Date: Tue, 12 Oct 2021 10:54:24 +0800	[thread overview]
Message-ID: <20211012025424.180781-1-davidcomponentone@gmail.com> (raw)

From: David Yang <davidcomponentone@gmail.com>

The coccinelle check report:
"./tools/tracing/latency/latency-collector.c:1541:10-16:
ERROR: application of sizeof to pointer"
Using the "strlen" to fix it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: David Yang <davidcomponentone@gmail.com>
---
 tools/tracing/latency/latency-collector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tracing/latency/latency-collector.c b/tools/tracing/latency/latency-collector.c
index 3a2e6bb781a8..b131007e6c70 100644
--- a/tools/tracing/latency/latency-collector.c
+++ b/tools/tracing/latency/latency-collector.c
@@ -1538,7 +1538,7 @@ static void tracing_loop(void)
 				mutex_lock(&print_mtx);
 				check_signals();
 				write_or_die(fd_stdout, queue_full_warning,
-					     sizeof(queue_full_warning));
+					     strlen(queue_full_warning) + 1);
 				mutex_unlock(&print_mtx);
 			}
 			modified--;
-- 
2.30.2


             reply	other threads:[~2021-10-12  2:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12  2:54 davidcomponentone [this message]
2021-10-12  3:06 ` [PATCH] Fix application of sizeof to pointer Steven Rostedt
2021-10-12 11:05   ` Viktor.Rosendahl
  -- strict thread matches above, loose matches on Subject: below --
2021-10-12  3:01 davidcomponentone
2021-10-12  7:01 ` David Hildenbrand
2021-10-12 11:16 davidcomponentone
2021-10-20 17:55 ` Andrii Nakryiko
2021-10-21  0:50   ` David Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012025424.180781-1-davidcomponentone@gmail.com \
    --to=davidcomponentone@gmail.com \
    --cc=Viktor.Rosendahl@bmw.de \
    --cc=colin.king@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vulab@iscas.ac.cn \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox