Re: [PATCH 1/5] x86: clk: Add config option to enable 48MHz fixed fch clk

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3498 bytes --]

Hi Ajit,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on rafael-pm/linux-next linus/master v5.15-rc5 next-20211011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ajit-Kumar-Pandey/x86-clk-Add-config-option-to-enable-48MHz-fixed-fch-clk/20211011-124732
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/f33c19d1cd863fd12fff7433a6bb22a2b0e22dfe
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ajit-Kumar-Pandey/x86-clk-Add-config-option-to-enable-48MHz-fixed-fch-clk/20211011-124732
        git checkout f33c19d1cd863fd12fff7433a6bb22a2b0e22dfe
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/clk/x86/clk-fch.c: In function 'fch_clk_remove':
>> drivers/clk/x86/clk-fch.c:81:23: error: variable 'fch_data' set but not used [-Werror=unused-but-set-variable]
      81 |  struct fch_clk_data *fch_data;
         |                       ^~~~~~~~
   cc1: all warnings being treated as errors


vim +/fch_data +81 drivers/clk/x86/clk-fch.c

421bf6a1f061a6 drivers/clk/x86/clk-st.c  Akshu Agrawal     2018-05-09  77  
d9b77361c1a515 drivers/clk/x86/clk-fch.c Akshu Agrawal     2020-07-31  78  static int fch_clk_remove(struct platform_device *pdev)
421bf6a1f061a6 drivers/clk/x86/clk-st.c  Akshu Agrawal     2018-05-09  79  {
19fe87fd854a92 drivers/clk/x86/clk-fch.c Akshu Agrawal     2020-07-31  80  	int i, clks;
19fe87fd854a92 drivers/clk/x86/clk-fch.c Akshu Agrawal     2020-07-31 @81  	struct fch_clk_data *fch_data;
19fe87fd854a92 drivers/clk/x86/clk-fch.c Akshu Agrawal     2020-07-31  82  
19fe87fd854a92 drivers/clk/x86/clk-fch.c Akshu Agrawal     2020-07-31  83  	fch_data = dev_get_platdata(&pdev->dev);
421bf6a1f061a6 drivers/clk/x86/clk-st.c  Akshu Agrawal     2018-05-09  84  
f33c19d1cd863f drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-10-11  85  	clks = ST_MAX_CLKS;
f33c19d1cd863f drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-10-11  86  
f33c19d1cd863f drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-10-11  87  	if (IS_ENABLED(CONFIG_CLK_FIXED_FCH))
f33c19d1cd863f drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-10-11  88  		clks = CLK_MAX_FIXED;
19fe87fd854a92 drivers/clk/x86/clk-fch.c Akshu Agrawal     2020-07-31  89  
19fe87fd854a92 drivers/clk/x86/clk-fch.c Akshu Agrawal     2020-07-31  90  	for (i = 0; i < clks; i++)
421bf6a1f061a6 drivers/clk/x86/clk-st.c  Akshu Agrawal     2018-05-09  91  		clk_hw_unregister(hws[i]);
19fe87fd854a92 drivers/clk/x86/clk-fch.c Akshu Agrawal     2020-07-31  92  
421bf6a1f061a6 drivers/clk/x86/clk-st.c  Akshu Agrawal     2018-05-09  93  	return 0;
421bf6a1f061a6 drivers/clk/x86/clk-st.c  Akshu Agrawal     2018-05-09  94  }
421bf6a1f061a6 drivers/clk/x86/clk-st.c  Akshu Agrawal     2018-05-09  95  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66028 bytes --]