Re: [PATCH v5 16/16] x86/tdx: Add cmdline option to force use of ioremap_host_shared

Michael S. Tsirkin
2021-10-15T06:57:34Z

On Thu, Oct 14, 2021 at 10:50:59PM -0700, Andi Kleen wrote:
>
> > I thought you basically create an OperationRegion of SystemMemory type,
> > and off you go. Maybe the OSPM in Linux is clever and protects
> > some memory, I wouldn't know.
>
>
> I investigated this now, and it looks like acpi is using ioremap_cache(). We
> can hook into that and force non sharing. It's probably safe to assume that
> this is not used on real IO devices.
>
> I think there are still some other BIOS mappings that use just plain
> ioremap() though.
>
>
> -Andi

Hmm don't you mean the reverse? If you make ioremap shared then OS is
protected from malicious ACPI? If you don't make it shared then
malicious ACPI can poke at arbitrary OS memory. Looks like making
ioremap non shared by default is actually less safe than shared.
Interesting.

For BIOS I suspect there's no way around it, it needs to be
audited since it's executable.

--
MST