From: Arnd Bergmann <arnd@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Marc Zyngier" <maz@kernel.org>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Sven Peter" <sven@svenpeter.dev>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] PCI: apple: select CONFIG_PCI_HOST_COMMON
Date: Wed, 13 Oct 2021 16:38:50 +0200 [thread overview]
Message-ID: <20211013143914.2133428-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
If this symbol is not already selected by another driver, pci-apple.o
fails to link:
aarch64-linux-ld: drivers/pci/controller/pcie-apple.o: in function `apple_pcie_probe':
pcie-apple.c:(.text+0xd28): undefined reference to `pci_host_common_probe'
Add another 'select' statement here, the same that is used for the
other drivers.
Fixes: a8bbe0366a3e ("PCI: apple: Add initial hardware bring-up")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/pci/controller/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index cc1fcc89c58f..5af99701e1f6 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -322,6 +322,7 @@ config PCIE_APPLE
depends on ARCH_APPLE || COMPILE_TEST
depends on OF
depends on PCI_MSI_IRQ_DOMAIN
+ select PCI_HOST_COMMON
help
Say Y here if you want to enable PCIe controller support on Apple
system-on-chips, like the Apple M1. This is required for the USB
--
2.29.2
next reply other threads:[~2021-10-13 14:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 14:38 Arnd Bergmann [this message]
2021-10-13 15:00 ` [PATCH] PCI: apple: select CONFIG_PCI_HOST_COMMON Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013143914.2133428-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox