* [PATCH] drm/tegra: mark nvdec_writel as inline
@ 2021-10-13 14:40 Arnd Bergmann
2021-10-18 13:56 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-10-13 14:40 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Daniel Vetter, Jonathan Hunter,
Mikko Perttunen
Cc: Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without CONFIG_IOMMU_API, the nvdec_writel() function is
unused, causing a warning:
drivers/gpu/drm/tegra/nvdec.c:48:13: error: 'nvdec_writel' defined but not used [-Werror=unused-function]
48 | static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)
| ^~~~~~~~~~~~
As this is a trivial wrapper around an inline function, mark
it as inline itself, which avoids the warning as well.
Fixes: e76599df354d ("drm/tegra: Add NVDEC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/tegra/nvdec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c
index 410333e05de8..791bf1acf5f0 100644
--- a/drivers/gpu/drm/tegra/nvdec.c
+++ b/drivers/gpu/drm/tegra/nvdec.c
@@ -45,7 +45,8 @@ static inline struct nvdec *to_nvdec(struct tegra_drm_client *client)
return container_of(client, struct nvdec, client);
}
-static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)
+static inline void nvdec_writel(struct nvdec *nvdec, u32 value,
+ unsigned int offset)
{
writel(value, nvdec->regs + offset);
}
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tegra: mark nvdec_writel as inline
2021-10-13 14:40 [PATCH] drm/tegra: mark nvdec_writel as inline Arnd Bergmann
@ 2021-10-18 13:56 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2021-10-18 13:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David Airlie, Daniel Vetter, Jonathan Hunter, Mikko Perttunen,
Arnd Bergmann, dri-devel, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Wed, Oct 13, 2021 at 04:40:58PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without CONFIG_IOMMU_API, the nvdec_writel() function is
> unused, causing a warning:
>
> drivers/gpu/drm/tegra/nvdec.c:48:13: error: 'nvdec_writel' defined but not used [-Werror=unused-function]
> 48 | static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)
> | ^~~~~~~~~~~~
>
> As this is a trivial wrapper around an inline function, mark
> it as inline itself, which avoids the warning as well.
>
> Fixes: e76599df354d ("drm/tegra: Add NVDEC driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/tegra/nvdec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-18 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-13 14:40 [PATCH] drm/tegra: mark nvdec_writel as inline Arnd Bergmann
2021-10-18 13:56 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox