* [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused
@ 2021-10-13 14:43 Arnd Bergmann
2021-10-14 1:29 ` Cai Huoqing
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2021-10-13 14:43 UTC (permalink / raw)
To: Cai Huoqing, Jonathan Cameron, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: Arnd Bergmann, Lars-Peter Clausen, Pengutronix Kernel Team,
NXP Linux Team, linux-iio, linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without CONFIG_PM_SLEEP, the runtime suspend/resume functions
are unused, producing a warning:
drivers/iio/adc/imx8qxp-adc.c:433:12: error: 'imx8qxp_adc_runtime_resume' defined but not used [-Werror=unused-function]
433 | static int imx8qxp_adc_runtime_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/iio/adc/imx8qxp-adc.c:419:12: error: 'imx8qxp_adc_runtime_suspend' defined but not used [-Werror=unused-function]
419 | static int imx8qxp_adc_runtime_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Mark them as __maybe_unused to shut up the compiler.
Fixes: 7bce634d02e6 ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iio/adc/imx8qxp-adc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
index 5030e0d8318d..901dd8e1b32f 100644
--- a/drivers/iio/adc/imx8qxp-adc.c
+++ b/drivers/iio/adc/imx8qxp-adc.c
@@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
return 0;
}
-static int imx8qxp_adc_runtime_suspend(struct device *dev)
+static __maybe_unused int imx8qxp_adc_runtime_suspend(struct device *dev)
{
struct iio_dev *indio_dev = dev_get_drvdata(dev);
struct imx8qxp_adc *adc = iio_priv(indio_dev);
@@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
return 0;
}
-static int imx8qxp_adc_runtime_resume(struct device *dev)
+static __maybe_unused int imx8qxp_adc_runtime_resume(struct device *dev)
{
struct iio_dev *indio_dev = dev_get_drvdata(dev);
struct imx8qxp_adc *adc = iio_priv(indio_dev);
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused
2021-10-13 14:43 [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused Arnd Bergmann
@ 2021-10-14 1:29 ` Cai Huoqing
2021-10-14 1:40 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Cai Huoqing @ 2021-10-14 1:29 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jonathan Cameron, Shawn Guo, Sascha Hauer, Fabio Estevam,
Arnd Bergmann, Lars-Peter Clausen, Pengutronix Kernel Team,
NXP Linux Team, linux-iio, linux-arm-kernel, linux-kernel
On 13 10月 21 16:43:26, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without CONFIG_PM_SLEEP, the runtime suspend/resume functions
> are unused, producing a warning:
>
> drivers/iio/adc/imx8qxp-adc.c:433:12: error: 'imx8qxp_adc_runtime_resume' defined but not used [-Werror=unused-function]
> 433 | static int imx8qxp_adc_runtime_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/iio/adc/imx8qxp-adc.c:419:12: error: 'imx8qxp_adc_runtime_suspend' defined but not used [-Werror=unused-function]
> 419 | static int imx8qxp_adc_runtime_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Mark them as __maybe_unused to shut up the compiler.
>
> Fixes: 7bce634d02e6 ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/iio/adc/imx8qxp-adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
> index 5030e0d8318d..901dd8e1b32f 100644
> --- a/drivers/iio/adc/imx8qxp-adc.c
> +++ b/drivers/iio/adc/imx8qxp-adc.c
> @@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static int imx8qxp_adc_runtime_suspend(struct device *dev)
> +static __maybe_unused int imx8qxp_adc_runtime_suspend(struct device *dev)
> {
> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct imx8qxp_adc *adc = iio_priv(indio_dev);
> @@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
> return 0;
> }
>
> -static int imx8qxp_adc_runtime_resume(struct device *dev)
> +static __maybe_unused int imx8qxp_adc_runtime_resume(struct device *dev)
> {
> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> struct imx8qxp_adc *adc = iio_priv(indio_dev);
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused
2021-10-14 1:29 ` Cai Huoqing
@ 2021-10-14 1:40 ` Randy Dunlap
2021-10-14 17:44 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-10-14 1:40 UTC (permalink / raw)
To: Cai Huoqing, Arnd Bergmann
Cc: Jonathan Cameron, Shawn Guo, Sascha Hauer, Fabio Estevam,
Arnd Bergmann, Lars-Peter Clausen, Pengutronix Kernel Team,
NXP Linux Team, linux-iio, linux-arm-kernel, linux-kernel
On 10/13/21 6:29 PM, Cai Huoqing wrote:
> On 13 10月 21 16:43:26, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Without CONFIG_PM_SLEEP, the runtime suspend/resume functions
>> are unused, producing a warning:
>>
>> drivers/iio/adc/imx8qxp-adc.c:433:12: error: 'imx8qxp_adc_runtime_resume' defined but not used [-Werror=unused-function]
>> 433 | static int imx8qxp_adc_runtime_resume(struct device *dev)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/adc/imx8qxp-adc.c:419:12: error: 'imx8qxp_adc_runtime_suspend' defined but not used [-Werror=unused-function]
>> 419 | static int imx8qxp_adc_runtime_suspend(struct device *dev)
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Mark them as __maybe_unused to shut up the compiler.
>>
>> Fixes: 7bce634d02e6 ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Cai Huoqing <caihuoqing@baidu.com>
Looks the same as
https://lore.kernel.org/all/20211013014658.2798-1-caihuoqing@baidu.com/
but that one is mixing the Fixes: tag.
>> ---
>> drivers/iio/adc/imx8qxp-adc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
>> index 5030e0d8318d..901dd8e1b32f 100644
>> --- a/drivers/iio/adc/imx8qxp-adc.c
>> +++ b/drivers/iio/adc/imx8qxp-adc.c
>> @@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
>> return 0;
>> }
>>
>> -static int imx8qxp_adc_runtime_suspend(struct device *dev)
>> +static __maybe_unused int imx8qxp_adc_runtime_suspend(struct device *dev)
>> {
>> struct iio_dev *indio_dev = dev_get_drvdata(dev);
>> struct imx8qxp_adc *adc = iio_priv(indio_dev);
>> @@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
>> return 0;
>> }
>>
>> -static int imx8qxp_adc_runtime_resume(struct device *dev)
>> +static __maybe_unused int imx8qxp_adc_runtime_resume(struct device *dev)
>> {
>> struct iio_dev *indio_dev = dev_get_drvdata(dev);
>> struct imx8qxp_adc *adc = iio_priv(indio_dev);
>> --
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused
2021-10-14 1:40 ` Randy Dunlap
@ 2021-10-14 17:44 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2021-10-14 17:44 UTC (permalink / raw)
To: Randy Dunlap
Cc: Cai Huoqing, Arnd Bergmann, Shawn Guo, Sascha Hauer,
Fabio Estevam, Arnd Bergmann, Lars-Peter Clausen,
Pengutronix Kernel Team, NXP Linux Team, linux-iio,
linux-arm-kernel, linux-kernel
On Wed, 13 Oct 2021 18:40:41 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 10/13/21 6:29 PM, Cai Huoqing wrote:
> > On 13 10月 21 16:43:26, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@arndb.de>
> >>
> >> Without CONFIG_PM_SLEEP, the runtime suspend/resume functions
> >> are unused, producing a warning:
> >>
> >> drivers/iio/adc/imx8qxp-adc.c:433:12: error: 'imx8qxp_adc_runtime_resume' defined but not used [-Werror=unused-function]
> >> 433 | static int imx8qxp_adc_runtime_resume(struct device *dev)
> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/iio/adc/imx8qxp-adc.c:419:12: error: 'imx8qxp_adc_runtime_suspend' defined but not used [-Werror=unused-function]
> >> 419 | static int imx8qxp_adc_runtime_suspend(struct device *dev)
> >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>
> >> Mark them as __maybe_unused to shut up the compiler.
> >>
> >> Fixes: 7bce634d02e6 ("iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Reviewed-by: Cai Huoqing <caihuoqing@baidu.com>
>
> Looks the same as
> https://lore.kernel.org/all/20211013014658.2798-1-caihuoqing@baidu.com/
>
> but that one is mixing the Fixes: tag.
Given Cai replied to this one and the presence of the fixes tag + my inherent
laziness, applied this one to the togreg branch of iio.git. I'll push that
out as testing to let 0-day poke it before pushing it out for next to pick up
in a day or 2.
Thanks,
Jonathan
>
> >> ---
> >> drivers/iio/adc/imx8qxp-adc.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/iio/adc/imx8qxp-adc.c b/drivers/iio/adc/imx8qxp-adc.c
> >> index 5030e0d8318d..901dd8e1b32f 100644
> >> --- a/drivers/iio/adc/imx8qxp-adc.c
> >> +++ b/drivers/iio/adc/imx8qxp-adc.c
> >> @@ -416,7 +416,7 @@ static int imx8qxp_adc_remove(struct platform_device *pdev)
> >> return 0;
> >> }
> >>
> >> -static int imx8qxp_adc_runtime_suspend(struct device *dev)
> >> +static __maybe_unused int imx8qxp_adc_runtime_suspend(struct device *dev)
> >> {
> >> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> >> struct imx8qxp_adc *adc = iio_priv(indio_dev);
> >> @@ -430,7 +430,7 @@ static int imx8qxp_adc_runtime_suspend(struct device *dev)
> >> return 0;
> >> }
> >>
> >> -static int imx8qxp_adc_runtime_resume(struct device *dev)
> >> +static __maybe_unused int imx8qxp_adc_runtime_resume(struct device *dev)
> >> {
> >> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> >> struct imx8qxp_adc *adc = iio_priv(indio_dev);
> >> --
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-14 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-13 14:43 [PATCH] iio: imx8qxp-adc: mark PM functions as __maybe_unused Arnd Bergmann
2021-10-14 1:29 ` Cai Huoqing
2021-10-14 1:40 ` Randy Dunlap
2021-10-14 17:44 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox