Re: [PATCH v2 0/2] tracing: Fix removal of eprobes and add test

Masami Hiramatsu
2021-10-13T23:16:12Z

On Wed, 13 Oct 2021 16:51:11 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> When doing the following:
>
> # echo 'e:hrstate timer/hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events
>
> # echo '-:hrstate timer/hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events
>
> It errors out with -ENOENT. This is because the "match" function does not
> take into account the "timer/hrtimer_cancel" part. Fix it and also make it
> work more genericly like kprobes and uprobes.

Thanks for update. This series looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
for the series.

Thank you!

>
> v1 at: https://lore.kernel.org/all/20211013234206.37dd18ffcc2a2cbf4493f125@kernel.org/
>
> Changes since v1:
> - Instead of just fixing the missing system/event, have it be more like
> kprobes and uprobes.
>
> Steven Rostedt (VMware) (2):
> tracing: Fix event probe removal from dynamic events
> selftests/ftrace: Update test for more eprobe removal process
>
> ----
> kernel/trace/trace_eprobe.c | 54 ++++++++++++++++++++--
> .../ftrace/test.d/dynevent/add_remove_eprobe.tc | 54 +++++++++++++++++++++-
> 2 files changed, 103 insertions(+), 5 deletions(-)

--
Masami Hiramatsu <mhiramat@kernel.org>