From: Christoph Hellwig <hch@lst.de>
To: Adam Manzanares <a.manzanares@samsung.com>
Cc: "yi.zhang@redhat.com" <yi.zhang@redhat.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"Keith Busch" <kbusch@kernel.org>, "Jens Axboe" <axboe@fb.com>,
"Christoph Hellwig" <hch@lst.de>,
"Javier González" <javier.gonz@samsung.com>,
"Minwoo Im" <minwoo.im.dev@gmail.com>,
"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: Cleanup per-namespace chardev deletion
Date: Thu, 14 Oct 2021 08:04:22 +0200 [thread overview]
Message-ID: <20211014060422.GA24897@lst.de> (raw)
In-Reply-To: <20211013150413.320133-1-a.manzanares@samsung.com>
On Wed, Oct 13, 2021 at 03:04:19PM +0000, Adam Manzanares wrote:
> Decrease reference count of chardevice during char device deletion in order to
> fix a kmemleak. Add relese function for the device associated chardev and moved
> ida_simple_remove into the release function.
>
> Fixes: 2637bae (nvme: introduce generic per-namespace chardev)
> Reported-by: Yi Zhang <yi.zhang@redhat.com>
> Suggested-by: Sagi Grimberg <sagi@grimberg.me>
> Signed-off-by: Adam Manzanares <a.manzanares@samsung.com>
This looks good, but the subject seems wrong. This isn't a cleanup
but a fix. I can fix up the subject when applying it.
prev parent reply other threads:[~2021-10-14 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211013150421uscas1p297a8bd51cf3f3b68dcef3a1c87da2959@uscas1p2.samsung.com>
2021-10-13 15:04 ` [PATCH] nvme: Cleanup per-namespace chardev deletion Adam Manzanares
2021-10-13 18:41 ` Javier González
2021-10-14 1:25 ` Yi Zhang
2021-10-14 6:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014060422.GA24897@lst.de \
--to=hch@lst.de \
--cc=a.manzanares@samsung.com \
--cc=axboe@fb.com \
--cc=javier.gonz@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=minwoo.im.dev@gmail.com \
--cc=sagi@grimberg.me \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox